chore: upgrade to styled-components 5 #514
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpellizzari
reviewed
Mar 15, 2021
There was a problem hiding this comment.
@foot I would expect some changes to the Code component around the animation errors we were seeing
Indeed! I assumed it was sc4/5 incompatibility but it seems quite broken in sc5. I'll TAL. Also it would be cool to re-build the docs/examples for each PR.. |
Converting to netlify should be no problem
It only happens |
- CircularProgress doesn't accept a number
- hideCloseButtonActive missing in example
- Use sc5 transient attributes ($loading) to avoid dom warnings
- Update ({ fill: props => props.foo }) to
(props => ({ fill: props.foo })) to fix fill warnings
|
Sorry for the premature review request, tests still need some attention. |
- To use react-test-renderer like the other tests - Was a bit tricky to make shallow + withTheme play nice
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://styled-components.com/docs/faqs#what-do-i-need-to-do-to-migrate-to-v5
fix: clicking on Code component
fix: react propType and dom attr warnings …
(props => ({ fill: props.foo })) to fix fill warnings