Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor add test file #1397

Merged
merged 10 commits into from
Feb 10, 2022
Merged

Refactor add test file #1397

merged 10 commits into from
Feb 10, 2022

Conversation

rokshana-b
Copy link
Contributor

What changed?

  • Removed redundant test cases
  • Added better fail mechanisms for util functions

Why?

  • Except for a few necessary ones, we dont need special tests for gitlab — we run all the tests on gitlab once a week
  • Util functions need to provider err msgs properly

@rokshana-b rokshana-b merged commit 420deef into main Feb 10, 2022
@rokshana-b rokshana-b deleted the refactor-add-tests branch February 10, 2022 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aclevername aclevername aclevername left review comments

@iahmad9 iahmad9 iahmad9 approved these changes

Assignees
No one assigned
Labels
exclude from release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rokshana-b @iahmad9 @aclevername