Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option for configuring PR settings in add/update profile #1463

Merged
merged 2 commits into from
Feb 18, 2022

Conversation

aclevername
Copy link
Contributor

@aclevername aclevername commented Feb 17, 2022

Closes: #1311

TODO: looking into updating acceptance test to check the PR settings, but might be overkill

What changed?
You can now configure the title, commit message, descripton and branch a PR is created on for add/update profiles

Why?
so you can customise the PR to meet your company standards. Also brings the PR flags in-line with what is available for add cluster

How did you test it?
manually:
add:

bin/gitops add profile --name podinfo --version 6.0.0 --namespace wego-system --cluster kind-e4xmcn --config-repo git@github.com:weaveworks-gitops-test/test-app-229w99at.git --base my-pr-branch --branch main --commit-message comitme --description "dogs>cats" --title="golden retreivers are the best"
► getting available profiles in kind-e4xmcn/wego-system
► created Pull Request: https://github.com/weaveworks-gitops-test/test-app-229w99at/pull/5
Adding profile:

Name: podinfo
Version: 6.0.0
Cluster: kind-e4xmcn
Namespace: wego-system

add-pr

Update:

bin/gitops update profile --name podinfo --version 6.0.1 --namespace wego-system --cluster kind-e4xmcn --config-repo git@github.com:weaveworks-gitops-test/test-app-229w99at.git --base my-pr-branch-2 --branch main --commit-message comitmeAGAIN --description "seriosuly though dogs>cats" --title="SERIOUSLY golden retreivers are the best"

► getting available profiles in kind-e4xmcn/wego-system
► created Pull Request: https://github.com/weaveworks-gitops-test/test-app-229w99at/pull/6
Updating profile:

Name: podinfo
Version: 6.0.1
Cluster: kind-e4xmcn
Namespace: wego-system

update-pr

Release notes
Add support for configuring PR options during add/update profile

Documentation Changes
no (the flags are enough documentation IMO)

Copy link
Contributor

@Himangini Himangini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice refactor 👍🏻

@aclevername aclevername merged commit f3337bd into main Feb 18, 2022
@makkes makkes deleted the profiles-pr branch December 9, 2022 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Subtask] Add gitops add command
3 participants