Skip to content
This repository has been archived by the owner on Jun 20, 2024. It is now read-only.

'pfring' instead of 'pcap' #6

Closed
rade opened this issue Aug 20, 2014 · 2 comments
Closed

'pfring' instead of 'pcap' #6

rade opened this issue Aug 20, 2014 · 2 comments
Labels
performance resolution/wontfix

Comments

@rade
Copy link
Member

rade commented Aug 20, 2014

Similar to #4... let's see whether pfring gives us better performance than pcap.
rade added a commit that referenced this issue Aug 20, 2014
@rade
initial, hacky, semi-working attempt at using 'pfring'
bd83c6e 
Am seeing much worse latency with this.
Can't seem to get injection to work.

issue #6
rade added a commit that referenced this issue Aug 20, 2014
@rade
oops
8dcafbb 
issue #6
rade added a commit that referenced this issue Aug 20, 2014
@rade
better work-around for broken pfring injection
5b0304b 
issue #6
rade added a commit that referenced this issue Aug 20, 2014
@rade
forgot some error handling
9642103 
issue #6
@rade
Copy link
Member Author

rade commented Aug 20, 2014

to get this to work at all I had to

  1. install pfring on my build machine; I followed the instructions at http://www.nmon.net/apt/
  2. add '-lnuma' to the LDFLAGS in the gopacket/pf_ring code

@rade
Copy link
Member Author

rade commented Sep 18, 2014

I can't see us wanting to invest time in this. -> WONTFIX

@rade rade closed this as completed Sep 18, 2014
@neilellis neilellis mentioned this issue Sep 25, 2014
Closed
tomwilkie pushed a commit to tomwilkie/weave that referenced this issue Mar 24, 2015
@bboreham
Merge pull request weaveworks#6 from tomwilkie/22_ip_allocation_b
f85a1c7 
LGTM
marccarre added a commit that referenced this issue Mar 13, 2017
@marccarre
Add failing test catching defunct launch.sh processses.
8a5e698 
Reproduces issue #2836.
Sample output:
test #5 "run_on mct-0.us-central1-a.weave-net ps aux | grep 'launch.sh' | grep defunct | wc -l" failed:
	expected "0"
	got "1"
test #6 "run_on mct-1.us-central1-a.weave-net ps aux | grep 'launch.sh' | grep defunct | wc -l" failed:
	expected "0"
	got "1"
test #7 "run_on mct-2.us-central1-a.weave-net ps aux | grep 'launch.sh' | grep defunct | wc -l" failed:
	expected "0"
	got "1"
3 of 8 tests failed in 61.780s.
marccarre added a commit that referenced this issue Mar 14, 2017
@marccarre
Add failing test catching defunct launch.sh processses.
abfc417 
Reproduces issue #2836.
Sample output:
test #5 "run_on mct-0.us-central1-a.weave-net ps aux | grep -c '[d]efunct'" failed:
	expected "0"
	got "1"
test #6 "run_on mct-1.us-central1-a.weave-net ps aux | grep -c '[d]efunct'" failed:
	expected "0"
	got "1"
test #7 "run_on mct-2.us-central1-a.weave-net ps aux | grep -c '[d]efunct'" failed:
	expected "0"
	got "1"
3 of 8 tests failed in 61.780s.
marccarre added a commit that referenced this issue Mar 14, 2017
@marccarre
Add failing test catching defunct launch.sh processses.
673d0af 
Reproduces issue #2836, i.e.:

- during initialisation:

```
$ ps auxf
[...]
root      1380  0.4  1.6 879660 60732 ?        Ssl  Mar13   5:54 /usr/bin/docker daemon -H fd:// -H unix:///
root      1664  0.0  0.4 502116 18540 ?        Ssl  Mar13   0:06  \_ docker-containerd -l /var/run/docker/li
root     12615  0.0  0.1 200496  5424 ?        Sl   14:38   0:00      \_ docker-containerd-shim c5637e5bbdcb
root     12629  6.2  1.6 296400 62312 ?        Ssl  14:38   0:00      |   \_ /home/weave/weaver --port=6783
root     12910  0.0  0.0   1524    68 ?        S    14:38   0:00      |       \_ /bin/sh /home/weave/launch.
root     13002  0.0  0.0   1772  1232 ?        S    14:38   0:00      |           \_ /bin/sh /home/weave/wea
root     13027  0.0  0.0   1772   320 ?        S    14:38   0:00      |               \_ /bin/sh /home/weave
root     13028  0.0  0.0  14656  2708 ?        S    14:38   0:00      |                   \_ curl -o /tmp/we
[...]
```

- after initialisation:

```
$ ps auxf
[...]
root      1380  0.4  1.6 879660 60732 ?        Ssl  Mar13   5:54 /usr/bin/docker daemon -H fd:// -H unix:///
root      1664  0.0  0.4 502116 18540 ?        Ssl  Mar13   0:06  \_ docker-containerd -l /var/run/docker/li
root     12615  0.0  0.1 200496  5424 ?        Sl   14:38   0:00      \_ docker-containerd-shim c5637e5bbdcb
root     12629  3.5  1.6 297460 63340 ?        Ssl  14:38   0:00      |   \_ /home/weave/weaver --port=6783
root     12910  0.0  0.0      0     0 ?        Z    14:38   0:00      |       \_ [launch.sh] <defunct>
[...]
```

Sample output:

```
test #5 "run_on mct-0.us-central1-a.weave-net ps aux | grep -c '[d]efunct'" failed:
	expected "0"
	got "1"
test #6 "run_on mct-1.us-central1-a.weave-net ps aux | grep -c '[d]efunct'" failed:
	expected "0"
	got "1"
test #7 "run_on mct-2.us-central1-a.weave-net ps aux | grep -c '[d]efunct'" failed:
	expected "0"
	got "1"
3 of 8 tests failed in 62.012s.
```
marccarre added a commit that referenced this issue May 4, 2017
@marccarre
Fix test #150: increase ping timeout.
5e7da57 
Increasing the ping timeout or adding `sleep 1` before failing assertion:

```
  test #6 "exec_on mct-0.us-central1-a.weave-net c1 ping -nq -W 2 -c 1 10.2.1.7" failed:
  	program terminated with code 1 instead of 0
  1 of 14 tests failed in 22.770s.
```

seems to consistently make the test pass.
marccarre added a commit that referenced this issue May 5, 2017
@marccarre
Fix test #150: increase ping timeout.
54e67ee 
Increasing the ping timeout or adding `sleep 1` before failing assertion:

```
  test #6 "exec_on mct-0.us-central1-a.weave-net c1 ping -nq -W 2 -c 1 10.2.1.7" failed:
  	program terminated with code 1 instead of 0
  1 of 14 tests failed in 22.770s.
```

seems to consistently make the test pass.
marccarre added a commit that referenced this issue May 5, 2017
@marccarre
Fix test #150: increase ping timeout.
18ba504 
Increasing the ping timeout or adding `sleep 1` before failing assertion:

```
  test #6 "exec_on mct-0.us-central1-a.weave-net c1 ping -nq -W 2 -c 1 10.2.1.7" failed:
  	program terminated with code 1 instead of 0
  1 of 14 tests failed in 22.770s.
```

seems to consistently make the test pass.
marccarre added a commit that referenced this issue May 8, 2017
@marccarre
Fix test #150: increase ping timeout.
db4afe9 
Increasing the ping timeout or adding `sleep 1` before failing assertion:

```
  test #6 "exec_on mct-0.us-central1-a.weave-net c1 ping -nq -W 2 -c 1 10.2.1.7" failed:
  	program terminated with code 1 instead of 0
  1 of 14 tests failed in 22.770s.
```

seems to consistently make the test pass.
marccarre added a commit that referenced this issue May 8, 2017
@marccarre
Fix test #150: increase ping timeout.
2a1ba91 
Increasing the ping timeout or adding `sleep 1` before failing assertion:

```
  test #6 "exec_on mct-0.us-central1-a.weave-net c1 ping -nq -W 2 -c 1 10.2.1.7" failed:
  	program terminated with code 1 instead of 0
  1 of 14 tests failed in 22.770s.
```

seems to consistently make the test pass.
marccarre added a commit that referenced this issue May 8, 2017
@marccarre
Fix test 150: increase ping timeout.
88c3023 
Increasing the ping timeout or adding `sleep 1` before failing assertion:

```
  test #6 "exec_on mct-0.us-central1-a.weave-net c1 ping -nq -W 2 -c 1 10.2.1.7" failed:
  	program terminated with code 1 instead of 0
  1 of 14 tests failed in 22.770s.
```

seems to consistently make the test pass.
marccarre added a commit that referenced this issue May 9, 2017
@marccarre
Fix test 150: increase ping timeout.
bbb5bb8 
Increasing the ping timeout or adding `sleep 1` before failing assertion:

```
  test #6 "exec_on mct-0.us-central1-a.weave-net c1 ping -nq -W 2 -c 1 10.2.1.7" failed:
  	program terminated with code 1 instead of 0
  1 of 14 tests failed in 22.770s.
```

seems to consistently make the test pass.
marccarre added a commit that referenced this issue May 9, 2017
@marccarre
Fix test 150: increase ping timeout.
680e4fe 
Increasing the ping timeout or adding `sleep 1` before failing assertion:

```
  test #6 "exec_on mct-0.us-central1-a.weave-net c1 ping -nq -W 2 -c 1 10.2.1.7" failed:
  	program terminated with code 1 instead of 0
  1 of 14 tests failed in 22.770s.
```

seems to consistently make the test pass.
marccarre added a commit that referenced this issue May 9, 2017
@marccarre
Fix tests following proxy merge.
637ba66 
- Fix test 660: pass arguments in correct order.
- Fix test 620: no double launch, weave stop instead of kill -9.

  - Now that router and proxy have been merged, we should only call `weave launch` once.
  - `sudo kill -9` was introduced because we previously had `docker kill` (see: http://github.com/weaveworks/weave/commit/cb73b738621d57727072ae998cdeaec337f23a1a), because we had no `weave stop-proxy` yet (see: http://github.com/weaveworks/weave/commit/e31f21a6d224d61de1d8a940ea4b0b45cebc9723). Pre-proxy-merge, this should just have been `weave stop-proxy`, and now that router and proxy have been merged, we should just call `weave stop`.

- Fix test 650: no double launch.
- Fix test 150: increase ping timeout.

  - Increasing the ping timeout or adding `sleep 1` before failing assertion:

```
  test #6 "exec_on mct-0.us-central1-a.weave-net c1 ping -nq -W 2 -c 1 10.2.1.7" failed:
  	program terminated with code 1 instead of 0
  1 of 14 tests failed in 22.770s.
```

    seems to consistently make the test pass.

- Fix test 630: remove redundant case & assertions.
- Fix test 090: remove irrelevant assertions.
marccarre added a commit that referenced this issue May 9, 2017
@marccarre
Fix tests following proxy merge.
5d8611b 
- Fix test 660: pass arguments in correct order.
- Fix test 620: no double launch, weave stop instead of kill -9.

  - Now that router and proxy have been merged, we should only call `weave launch` once.
  - `sudo kill -9` was introduced because we previously had `docker kill` (see: http://github.com/weaveworks/weave/commit/cb73b738621d57727072ae998cdeaec337f23a1a), because we had no `weave stop-proxy` yet (see: http://github.com/weaveworks/weave/commit/e31f21a6d224d61de1d8a940ea4b0b45cebc9723). Pre-proxy-merge, this should just have been `weave stop-proxy`, and now that router and proxy have been merged, we should just call `weave stop`.

- Fix test 650: no double launch.
- Fix test 150: increase ping timeout.

  - Increasing the ping timeout or adding `sleep 1` before failing assertion:

```
  test #6 "exec_on mct-0.us-central1-a.weave-net c1 ping -nq -W 2 -c 1 10.2.1.7" failed:
  	program terminated with code 1 instead of 0
  1 of 14 tests failed in 22.770s.
```

    seems to consistently make the test pass.

- Fix test 630: remove redundant case & assertions.
- Fix test 090: remove irrelevant assertions.
marccarre added a commit that referenced this issue May 9, 2017
@marccarre
Fix tests following proxy merge.
aa1a7e0 
- Fix test 660: pass arguments in correct order.
- Fix test 620: no double launch, weave stop instead of kill -9.

  - Now that router and proxy have been merged, we should only call `weave launch` once.
  - `sudo kill -9` was introduced because we previously had `docker kill` (see: http://github.com/weaveworks/weave/commit/cb73b738621d57727072ae998cdeaec337f23a1a), because we had no `weave stop-proxy` yet (see: http://github.com/weaveworks/weave/commit/e31f21a6d224d61de1d8a940ea4b0b45cebc9723). Pre-proxy-merge, this should just have been `weave stop-proxy`, and now that router and proxy have been merged, we should just call `weave stop`.

- Fix test 650: no double launch.
- Fix test 150: increase ping timeout.

  - Increasing the ping timeout or adding `sleep 1` before failing assertion:

```
  test #6 "exec_on mct-0.us-central1-a.weave-net c1 ping -nq -W 2 -c 1 10.2.1.7" failed:
  	program terminated with code 1 instead of 0
  1 of 14 tests failed in 22.770s.
```

    seems to consistently make the test pass.

- Fix test 630: remove redundant case & assertions.
- Fix test 090: remove irrelevant assertions.
marccarre added a commit that referenced this issue May 9, 2017
@marccarre
Fix tests following proxy merge.
d5bdfc2 
- Fix test 660: pass arguments in correct order.
- Fix test 620: no double launch, weave stop instead of kill -9.

  - Now that router and proxy have been merged, we should only call `weave launch` once.
  - `sudo kill -9` was introduced because we previously had `docker kill` (see: http://github.com/weaveworks/weave/commit/cb73b738621d57727072ae998cdeaec337f23a1a), because we had no `weave stop-proxy` yet (see: http://github.com/weaveworks/weave/commit/e31f21a6d224d61de1d8a940ea4b0b45cebc9723). Pre-proxy-merge, this should just have been `weave stop-proxy`, and now that router and proxy have been merged, we should just call `weave stop`.

- Fix test 650: no double launch.
- Fix test 150: increase ping timeout.

  - Increasing the ping timeout or adding `sleep 1` before failing assertion:

```
  test #6 "exec_on mct-0.us-central1-a.weave-net c1 ping -nq -W 2 -c 1 10.2.1.7" failed:
  	program terminated with code 1 instead of 0
  1 of 14 tests failed in 22.770s.
```

    seems to consistently make the test pass.

- Fix test 630: remove redundant case & assertions.
- Fix test 090: remove irrelevant assertions.
marccarre added a commit that referenced this issue May 9, 2017
@marccarre
Fix tests following proxy merge.
74d9ef7 
Remove tests of situations that don't exist any more and fix the following tests:

- Fix test 660: pass arguments in correct order.
- Fix test 620: no double launch, weave stop instead of kill -9.

  - Now that router and proxy have been merged, we should only call `weave launch` once.
  - `sudo kill -9` was introduced because we previously had `docker kill` (see: http://github.com/weaveworks/weave/commit/cb73b738621d57727072ae998cdeaec337f23a1a), because we had no `weave stop-proxy` yet (see: http://github.com/weaveworks/weave/commit/e31f21a6d224d61de1d8a940ea4b0b45cebc9723). Pre-proxy-merge, this should just have been `weave stop-proxy`, and now that router and proxy have been merged, we should just call `weave stop`.

- Fix test 650: no double launch.
- Fix test 150: increase ping timeout.

  - Increasing the ping timeout or adding `sleep 1` before failing assertion:

```
  test #6 "exec_on mct-0.us-central1-a.weave-net c1 ping -nq -W 2 -c 1 10.2.1.7" failed:
    program terminated with code 1 instead of 0
  1 of 14 tests failed in 22.770s.
```

    seems to consistently make the test pass.

- Fix test 630: remove redundant case & assertions.
- Fix test 090: remove irrelevant assertions.
marccarre added a commit that referenced this issue May 9, 2017
@marccarre
Fix tests following proxy merge.
3fcb133 
Remove tests of situations that don't exist any more and fix the following tests:

- Fix test 660: pass arguments in correct order.
- Fix test 620: no double launch, weave stop instead of kill -9.

  - Now that router and proxy have been merged, we should only call `weave launch` once.
  - `sudo kill -9` was introduced because we previously had `docker kill` (see: http://github.com/weaveworks/weave/commit/cb73b738621d57727072ae998cdeaec337f23a1a), because we had no `weave stop-proxy` yet (see: http://github.com/weaveworks/weave/commit/e31f21a6d224d61de1d8a940ea4b0b45cebc9723). Pre-proxy-merge, this should just have been `weave stop-proxy`, and now that router and proxy have been merged, we should just call `weave stop`.

- Fix test 650: no double launch.
- Fix test 150: increase ping timeout.

  - Increasing the ping timeout or adding `sleep 1` before failing assertion:

```
  test #6 "exec_on mct-0.us-central1-a.weave-net c1 ping -nq -W 2 -c 1 10.2.1.7" failed:
    program terminated with code 1 instead of 0
  1 of 14 tests failed in 22.770s.
```

    seems to consistently make the test pass.

- Fix test 630: remove redundant case & assertions.
- Fix test 090: remove irrelevant assertions.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
performance resolution/wontfix
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rade