Skip to content
This repository has been archived by the owner on Jun 20, 2024. It is now read-only.

Build container FROM golang:1.7.3 #2529

Merged
merged 5 commits into from
Nov 17, 2016
Merged

Build container FROM golang:1.7.3 #2529

merged 5 commits into from
Nov 17, 2016

Conversation

awh
Copy link
Contributor

@awh awh commented Sep 28, 2016

Fixes #2522.

@awh awh added this to the 1.8.0 milestone Sep 28, 2016
@awh awh force-pushed the use-golang-171 branch 2 times, most recently from 64de95e to 713b21b Compare October 6, 2016 15:40
@awh
Copy link
Contributor Author

awh commented Oct 7, 2016

golint appears to have sprouted some additional checks which we need to address (or disable)

@awh
Copy link
Contributor Author

awh commented Oct 7, 2016

See #2522 (comment) before merging

@awh awh modified the milestones: 1.8.0, overflow Oct 11, 2016
@awh awh modified the milestones: 1.9.0, overflow Nov 9, 2016
@awh awh changed the title Build container FROM golang:1.7.1 Build container FROM golang:1.7.3 Nov 9, 2016
@awh
Copy link
Contributor Author

awh commented Nov 9, 2016

I have tested this successfully with Docker 1.6.0 -> 1.12.3 inclusive, to make sure the malformed host header fix works as intended:

for v in 1.9.0 1.9.1 1.10.0 1.10.1 1.10.2 1.10.3 1.11.0 1.11.1 1.11.2 1.12.0 1.12.1 1.12.2 1.12.3 1.8.0 1.8.1 1.8.2 1.8.3 1.7.1 1.6.2 1.6.1 1.6.0; do wget https://get.docker.com/builds/Linux/x86_64/docker-$v.tgz; done
for file in *.tgz; do tar -x -z --one-top-level -f $file; done
for d in $(find -type f -name docker); do sudo $d -H=unix:///var/run/weave/weave.sock version > /dev/null  || echo $d failed; done

@awh awh force-pushed the use-golang-171 branch 5 times, most recently from 74babfc to bf7bb3d Compare November 14, 2016 13:23

// MalformedHostHeaderOverride is a wrapper to be able
// to overcome the 400 Bad request coming from old docker
// clients that send an invalid Host header.

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

}

// Accept makes the listener accepts connections and wraps the connection
// in a MalformedHostHeaderOverrideConn initilizing first to true.

This comment was marked as abuse.

This comment was marked as abuse.

@awh awh removed their assignment Nov 17, 2016
@bboreham bboreham merged commit af732d0 into master Nov 17, 2016
@bboreham bboreham deleted the use-golang-171 branch March 10, 2017 11:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants