This repository has been archived by the owner on Jun 20, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awh
force-pushed
the
use-golang-171
branch
2 times, most recently
from
October 6, 2016 15:40
64de95e
to
713b21b
Compare
|
See #2522 (comment) before merging |
awh
changed the title
Build container FROM golang:1.7.1
Build container FROM golang:1.7.3
Nov 9, 2016
I have tested this successfully with Docker 1.6.0 -> 1.12.3 inclusive, to make sure the malformed host header fix works as intended:
|
awh
force-pushed
the
use-golang-171
branch
5 times, most recently
from
November 14, 2016 13:23
74babfc
to
bf7bb3d
Compare
marccarre
reviewed
Nov 15, 2016
|
||
// MalformedHostHeaderOverride is a wrapper to be able | ||
// to overcome the 400 Bad request coming from old docker | ||
// clients that send an invalid Host header. |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
} | ||
|
||
// Accept makes the listener accepts connections and wraps the connection | ||
// in a MalformedHostHeaderOverrideConn initilizing first to true. |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2522.