This repository has been archived by the owner on Jun 20, 2024. It is now read-only.
Improve 'expecting PMTU update' message with address #3603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also remove "EMGSIZE" because it looks like an error in the log file.
|
LGTM |
|
After discussion IRL I moved the message to debug level. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Debugging an issue yesterday I realised this message is nearly useless because you have no idea which connection it refers to.
Also remove
EMGSIZEbecause it catches the eye and looks like an error in the log file.Maybe we should just remove this message, or move it to debug level? I'm not sure why we need it.