This repository has been archived by the owner on Jun 20, 2024. It is now read-only.
Build with Go 1.12.7; Added support for crossbuilding s390x binaries and images #3685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, Any updates on this pull request changes? |
|
Thanks for the PR; was a bit focused on fixing #3680 which is causing every CI build to fail. |
bboreham
changed the title
|
Rebased and ran CI successfully at https://circleci.com/workflow-run/9252a5a6-fa29-4d42-97ae-0fbec62c05ea |
|
@bboreham any plans on merging these PR changes? |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes details:
In Makefile have added cross build support w.r.t s390x .
Updated the build/Dockerfile to substitute
golang:1.10.1-stretchwithgolang:1.12.7-buster. As the debian:buster image already has crossbuild-essential-${platform} binaries in it's repo, so I have removed the addition of emdebian repository in the repolists which was used earlier that referred to the crossbuild-essential binaries.I have verified and tested native and cross ARCH build of binaries and Images with these changes.