chore: remove ajv schema verification of modern configuration (#4911)

.changeset/eighty-scissors-drop.md

@@ -0,0 +1,22 @@
+---
+'@modern-js/plugin-router-v5': minor
+'@modern-js/plugin-garfish': minor
+'@modern-js/runtime': minor
+'@modern-js/plugin-testing': minor
+'@modern-js/module-tools': minor
+'@modern-js/plugin-worker': minor
+'@modern-js/plugin-tailwindcss': minor
+'@modern-js/app-tools': minor
+'@modern-js/main-doc': minor
+'@modern-js/plugin-proxy': minor
+'@modern-js/plugin-devtools': minor
+'@modern-js/plugin-bff': minor
+'@modern-js/plugin-ssg': minor
+'@modern-js/plugin-swc': minor
+'@modern-js/utils': minor
+'@modern-js/core': minor
+'@scripts/prebundle': minor
+---
+
+chore: remove ajv schema verification of configuration
+chore: 移除 ajv 对项目配置的校验

packages/cli/core/src/config/createResolvedConfig.ts

@@ -1,13 +1,5 @@
-import { createDebugger, logger } from '@modern-js/utils';
-import type { ErrorObject } from '@modern-js/utils/ajv';
-import { patchSchema } from '../schema/patchSchema';
-import type {
-  UserConfig,
-  NormalizedConfig,
-  LoadedConfig,
-  PluginValidateSchema,
-} from '../types';
-import { repeatKeyWarning } from '../utils/repeatKeyWarning';
+import { createDebugger } from '@modern-js/utils';
+import type { UserConfig, NormalizedConfig, LoadedConfig } from '../types';
 import { mergeConfig } from '../utils/mergeConfig';
 import { createDefaultConfig } from './createDefaultConfig';
 
@@ -17,64 +9,9 @@ export const createResolveConfig = async (
   // eslint-disable-next-line @typescript-eslint/ban-types
   loaded: LoadedConfig<{}>,
   configs: UserConfig[],
-  schemas: PluginValidateSchema[],
-  onSchemaError?: (error: ErrorObject) => void | Promise<void>,
 ): Promise<NormalizedConfig> => {
-  const { default: Ajv } = await import('@modern-js/utils/ajv');
-  const { default: ajvKeywords } = await import(
-    '@modern-js/utils/ajv-keywords'
-  );
-  const { default: betterAjvErrors } = await import(
-    '@modern-js/utils/better-ajv-errors'
-  );
-
-  const { config: userConfig, jsConfig, pkgConfig } = loaded;
-
-  const ajv = new Ajv({ $data: true, strict: false });
-
-  ajvKeywords(ajv);
-
-  const validateSchema = patchSchema(schemas);
-  const validate = ajv.compile(validateSchema);
-
-  repeatKeyWarning(validateSchema, jsConfig, pkgConfig);
-
-  // validate user config.
-  const valid = validate(userConfig);
-
-  const formatValidateError = (config: UserConfig) =>
-    betterAjvErrors(
-      validateSchema,
-      config,
-      validate.errors?.map(e => ({
-        ...e,
-        dataPath: e.instancePath,
-      })),
-      {
-        indent: 2,
-      },
-    );
-
-  if (!valid && validate.errors?.length) {
-    if (onSchemaError) {
-      await onSchemaError(validate?.errors[0]);
-    }
-    const errors = formatValidateError(userConfig);
-    logger.log(errors);
-    throw new Error(`Validate configuration error`);
-  }
-
-  // validate config from plugins.
-  for (const config of configs) {
-    if (!validate(config)) {
-      const errors = formatValidateError(config);
-      logger.error(errors);
-      throw new Error(`Validate configuration error.`);
-    }
-  }
-
+  const { config: userConfig } = loaded;
   const resolved = mergeConfig([createDefaultConfig(), ...configs, userConfig]);
-
   debug('resolved %o', resolved);
 
   return resolved;

packages/cli/core/src/createCli.ts

@@ -119,14 +119,7 @@ export const createCli = () => {
 
     const extraConfigs = await hooksRunner.config();
 
-    const extraSchemas = await hooksRunner.validateSchema();
-
-    const normalizedConfig = await createResolveConfig(
-      loaded,
-      extraConfigs,
-      extraSchemas,
-      options?.onSchemaError,
-    );
+    const normalizedConfig = await createResolveConfig(loaded, extraConfigs);
 
     const { resolved } = await hooksRunner.resolvedConfig({
       resolved: normalizedConfig,

packages/cli/core/src/manager.ts

@@ -19,7 +19,6 @@ const baseHooks: BaseHooks<{}> = {
   beforeConfig: createAsyncWorkflow(),
   config: createParallelWorkflow(),
   resolvedConfig: createAsyncWaterfall(),
-  validateSchema: createParallelWorkflow(),
   prepare: createAsyncWorkflow(),
   afterPrepare: createAsyncWorkflow(),
   commands: createAsyncWorkflow(),

packages/cli/core/src/types/coreOptions.ts

@@ -1,4 +1,3 @@
-import type { ErrorObject } from '@modern-js/utils/compiled/ajv';
 import type { InternalPlugins } from './plugin';
 import type { UserConfig } from './config';
 
@@ -17,7 +16,6 @@ export interface CoreOptions {
     server?: InternalPlugins;
     autoLoad?: InternalPlugins;
   };
-  onSchemaError?: (error: ErrorObject) => void;
   options?: {
     metaName?: string;
     srcDir?: string;

packages/cli/core/src/types/hooks.ts

@@ -27,7 +27,6 @@ export type BaseHooks<
   resolvedConfig: AsyncWaterfall<{
     resolved: NormalizedConfig<Extends>;
   }>;
-  validateSchema: ParallelWorkflow<void>;
   prepare: AsyncWorkflow<void, void>;
   afterPrepare: AsyncWorkflow<void, void>;
   watchFiles: ParallelWorkflow<

packages/cli/core/src/types/index.ts

@@ -1,13 +1,6 @@
-import type { JSONSchemaType } from '@modern-js/utils/ajv/json-schema';
-
 export * from './plugin';
 export * from './config';
 export * from './pluginAPI';
 export * from './hooks';
 export * from './context';
 export * from './coreOptions';
-
-export interface PluginValidateSchema {
-  target: string;
-  schema: JSONSchemaType<any>;
-}

packages/cli/core/src/utils/index.ts

@@ -2,5 +2,4 @@ export * from './commander';
 export * from './createFileWatcher';
 export * from './initAppDir';
 export * from './mergeConfig';
-export * from './repeatKeyWarning';
 export * from './checkIsDuplicationPlugin';