-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: some link should not have as attributes #4575
Conversation
🦋 Changeset detectedLatest commit: 2e3252e The changes in this PR will be included in the next version bump. This PR includes changesets to release 253 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #4575 +/- ##
==========================================
- Coverage 57.59% 53.85% -3.75%
==========================================
Files 672 656 -16
Lines 17794 17983 +189
Branches 3876 4149 +273
==========================================
- Hits 10249 9685 -564
- Misses 6934 7642 +708
- Partials 611 656 +45 ☔ View full report in Codecov by Sentry. |
Summary
🤖 Generated by Copilot at 2e3252e
This pull request fixes a bug in the preload headers for the
@modern-js/prod-server
and@modern-js/server-core
packages. It makes thetype
property optional in thePreloadInclude
type and removes a redundant test case.Details
🤖 Generated by Copilot at 2e3252e
type
property optional inPreloadInclude
type inserver.ts
(link)type
property inpreload.test.ts
(link)@modern-js/prod-server
and@modern-js/server-core
in.changeset/dull-bees-yell.md
(link)Related Issue
Checklist
pnpm run change
.