-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(builder): add code pointer for check syntax results #4584
Conversation
🦋 Changeset detectedLatest commit: 7c0d760 The changes in this PR will be included in the next version bump. This PR includes changesets to release 252 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #4584 +/- ##
==========================================
- Coverage 57.59% 54.08% -3.52%
==========================================
Files 672 651 -21
Lines 17794 17899 +105
Branches 3876 4125 +249
==========================================
- Hits 10249 9680 -569
- Misses 6934 7567 +633
- Partials 611 652 +41 ☔ View full report in Codecov by Sentry. |
Summary
Sometimes the error code cannot be parsed by source map, so we need to add a pointer for this type of result to make it more clearer.
Old:
New:
🤖 Generated by Copilot at 7686ece
This pull request enhances the
CheckSyntaxPlugin
of the@modern-js/builder-shared
package by adding a code pointer feature and a unit test. It also updates the changeset file and adjusts the output formatting.Details
🤖 Generated by Copilot at 7686ece
@modern-js/builder-shared
package (link)displayCodePointer
to show a code snippet with a yellow arrow pointing to the error location (link, link, link)generateError
function (link)generateError
function (link)printMain
function to improve the alignment of the output (link)Related Issue
Checklist
pnpm run change
.