fix(builder): assetsRetry should work when htmlPlugin.inject false #4600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 8c0360f The changes in this PR will be included in the next version bump. This PR includes changesets to release 252 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #4600 +/- ##
==========================================
- Coverage 57.59% 54.06% -3.54%
==========================================
Files 672 652 -20
Lines 17794 17902 +108
Branches 3876 4128 +252
==========================================
- Hits 10249 9679 -570
- Misses 6934 7571 +637
- Partials 611 652 +41 ☔ View full report in Codecov by Sentry. |
chenjiahan
reviewed
Sep 7, 2023
packages/document/builder-doc/docs/zh/config/output/assetsRetry.md
Outdated
Show resolved
Hide resolved
…y.md Co-authored-by: neverland <chenjiahan.jait@bytedance.com>
9aoy
commented
Sep 7, 2023
packages/document/builder-doc/docs/en/config/output/assetsRetry.md
Outdated
Show resolved
Hide resolved
chenjiahan
approved these changes
Sep 7, 2023
This was referenced Sep 13, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
🤖 Generated by Copilot at 07ba38c
This pull request fixes the issue that the assets retry feature does not work when the
htmlPlugin.injectoption is false. It preserves therelandasattributes for the<link>tags when retrying assets, uses thealterAssetTagGroupshook to inject the assets retry script, and updates the documentation and tests accordingly.Details
🤖 Generated by Copilot at 07ba38c
@modern-js/builder-sharedpackage (link)alterAssetTagGroupshook instead of theafterTemplateExecutionhook to inject the assets retry script inAssetsRetryPlugin.ts(link)relandasattributes from the original<link>tag to the new<link>tag when creating the element for retrying inassetsRetry.ts(link)relandasattributes in the string representation of the new<link>tag when creating the element for retrying inassetsRetry.ts(link)assetsRetry.jsfile to reflect the changes inassetsRetry.ts(link)assetsRetry.md(link, link)index.test.tsthat checks the order of the assets retry script, the convert to rem script, the normal resource script, and the template custom resource script in the output HTML file (link)index.jsthat imports a CSS file and logs a message to the console (link)index.cssto be imported by the test entry file (link)index.htmlthat has a custom script tag and placeholders for the head and body tags (link)Related Issue
Checklist
pnpm run change.