-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: emit modern.config.json when distPath.root is absolute path #4649
fix: emit modern.config.json when distPath.root is absolute path #4649
Conversation
🦋 Changeset detectedLatest commit: 0306ca9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 254 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #4649 +/- ##
==========================================
- Coverage 57.59% 53.58% -4.02%
==========================================
Files 672 665 -7
Lines 17794 18123 +329
Branches 3876 4157 +281
==========================================
- Hits 10249 9711 -538
- Misses 6934 7754 +820
- Partials 611 658 +47 ☔ View full report in Codecov by Sentry. |
Summary
Fix failed to emit modern.config.json when distPath.root is absolute path.
🤖 Generated by Copilot at 0306ca9
This pull request fixes a bug that prevented the
modern.config.json
file from being emitted when thedistPath.root
option was set to an absolute path in the app configuration. It also adds a utility function to resolve absolute paths, updates the documentation and the changeset for the affected packages, and adds a new integration test case for the customdistPath.root
scenario.Details
🤖 Generated by Copilot at 0306ca9
modern.config.json
when thedistPath.root
is an absolute path (link)ensureAbsolutePath
utility function from@modern-js/utils
to resolve the absolute path of themodern.config.json
file in the@modern-js/prod-server
and@modern-js/app-tools
packages (link, link, link, link)distPath
configuration option to explain the meaning and usage of theroot
property and clarify that other properties underdistPath
can only be relative paths (link, link)custom-dist-path
scenario, which sets thedistPath.root
to an absolute path and verifies that themodern.config.json
and theindex.html
files are correctly output to the custom path (link, link, link, link, link)Related Issue
Checklist
pnpm run change
.