-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(builder): resolve-url-loader performance regression issue #4659
fix(builder): resolve-url-loader performance regression issue #4659
Conversation
🦋 Changeset detectedLatest commit: c2665af The changes in this PR will be included in the next version bump. This PR includes changesets to release 255 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #4659 +/- ##
==========================================
- Coverage 57.59% 53.75% -3.85%
==========================================
Files 672 664 -8
Lines 17794 18087 +293
Branches 3876 4140 +264
==========================================
- Hits 10249 9722 -527
- Misses 6934 7710 +776
- Partials 611 655 +44 ☔ View full report in Codecov by Sentry. |
Summary
'resolve-url-loader' relies on 'adjust-sourcemap-loader', it has performance regression issues in some scenarios, so we need to disable the sourceMap option.
🤖 Generated by Copilot at 8950cec
This pull request fixes a performance regression issue in the Sass loader plugins for both Webpack and Rollup bundlers. It does so by disabling source maps in the
resolve-url-loader
dependency, which is used to resolve relative URLs in Sass files.Details
🤖 Generated by Copilot at 8950cec
resolve-url-loader
to fix performance regression issue in Sass files (link, link)@modern-js/builder-webpack-provider
and@modern-js/builder-rspack-provider
packages in English and Chinese (link)Related Issue
Checklist
pnpm run change
.