-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(builder): unify progress bar style in webpack / Rspack mode #4665
Conversation
🦋 Changeset detectedLatest commit: 31b4799 The changes in this PR will be included in the next version bump. This PR includes changesets to release 255 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #4665 +/- ##
==========================================
- Coverage 57.59% 53.73% -3.86%
==========================================
Files 672 664 -8
Lines 17794 18089 +295
Branches 3876 4142 +266
==========================================
- Hits 10249 9721 -528
- Misses 6934 7712 +778
- Partials 611 656 +45 ☔ View full report in Codecov by Sentry. |
Summary
Ref: web-infra-dev/rspack#4197
🤖 Generated by Copilot at 31b4799
This pull request updates the builder packages to improve the consistency and compatibility of the webpack and rspack modes. It uses some helper modules from
builder-shared
to format and color the progress bars and the compilation output. It also adjusts the precision of the prettyTime function and adds a changeset file to document the changes.Details
🤖 Generated by Copilot at 31b4799
createCompiler
module (link, link)progress
module from the builder-shared package, which contains thegetProgressColor
function (link)progress
module to the builder-shared package, which contains thegetProgressColor
function (link)bar
module to match the style of the rspack mode, and to use thegetProgressColor
function to color the icon based on the target index (link, link, link, link)getProgressColor
function in thebus
module to manage the states and the output of the progress bars (link, link)prettyTime
function in theProgressPlugin
module to one decimal place to match the rspack mode (link)Related Issue
Checklist
pnpm run change
.