-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(builder): move duplicated prebundle packages to shared #4666
chore(builder): move duplicated prebundle packages to shared #4666
Conversation
🦋 Changeset detectedLatest commit: 45d0d2f The changes in this PR will be included in the next version bump. This PR includes changesets to release 255 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #4666 +/- ##
==========================================
- Coverage 57.59% 53.74% -3.86%
==========================================
Files 672 664 -8
Lines 17794 18089 +295
Branches 3876 4142 +266
==========================================
- Hits 10249 9722 -527
- Misses 6934 7711 +777
- Partials 611 656 +45 ☔ View full report in Codecov by Sentry. |
Summary
🤖 Generated by Copilot at f85d423
This pull request moves the prebundle packages
pretty-time
andwebpack-merge
from the local compiled folders of@modern-js/builder-rspack-provider
and@modern-js/builder-webpack-provider
to the shared package@modern-js/builder-shared
. It also updates the imports and types of these packages in the relevant modules and adds a changeset file to document the patch updates.Details
🤖 Generated by Copilot at f85d423
@modern-js/builder-webpack-provider
,@modern-js/builder-rspack-provider
, and@modern-js/builder-shared
(link)pretty-time
andwebpack-merge
from@modern-js/builder-webpack-provider
and@modern-js/builder-rspack-provider
to@modern-js/builder-shared
(link, link, link, link, link, link, link, link, link, link, link, link)pretty-time
andwebpack-merge
from the local compiled folders to the@modern-js/builder-shared
package in thecreateCompiler
,getConfigUtils
, andProgressPlugin
modules of@modern-js/builder-webpack-provider
and@modern-js/builder-rspack-provider
(link, link, link, link, link)mergeConfig
from the local compiled folders to the@modern-js/builder-shared
package in theModifyWebpackConfigUtils
andModifyRspackConfigUtils
types of@modern-js/builder-webpack-provider
and@modern-js/builder-rspack-provider
(link, link)pretty-time
andwebpack-merge
in thepackage.json
of the@modern-js/builder-shared
package (link, link)Related Issue
Checklist
pnpm run change
.