-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(app-tools): add RouterPlugin name #4667
Conversation
🦋 Changeset detectedLatest commit: 64050ea The changes in this PR will be included in the next version bump. This PR includes changesets to release 255 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #4667 +/- ##
==========================================
- Coverage 57.59% 53.74% -3.86%
==========================================
Files 672 664 -8
Lines 17794 18090 +296
Branches 3876 4142 +266
==========================================
- Hits 10249 9723 -526
- Misses 6934 7711 +777
- Partials 611 656 +45 ☔ View full report in Codecov by Sentry. |
Summary
🤖 Generated by Copilot at 94e0c5a
This pull request enhances the
RouterPlugin
for the SSR mode by allowing custom names and generating a router manifest file. It also updates the@modern-js/app-tools
and@modern-js/utils
packages and adds a changeset file.Details
🤖 Generated by Copilot at 94e0c5a
@modern-js/app-tools
and@modern-js/utils
packages (link)pluginName
argument to theapplyRouterPlugin
function in theadapterSSR.ts
file to allow different names for theRouterPlugin
instance depending on the context (link)pluginName
parameter to theapplyRouterPlugin
function signature and use it to identify theRouterPlugin
instance in the webpack chain (link, link)name
property to theRouterPlugin
class to provide a human-readable name for the plugin (link)ROUTER_MANIFEST
to theCHAIN_ID
enum to identify theRouterPlugin
instance that generates the router manifest file for the SSR mode (link)Related Issue
Checklist
pnpm run change
.