-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove legacy monorepo include and unused utils #4752
Conversation
🦋 Changeset detectedLatest commit: 8d7a2a9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 259 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4752 +/- ##
==========================================
- Coverage 57.59% 50.55% -7.04%
==========================================
Files 672 691 +19
Lines 17794 19128 +1334
Branches 3876 4397 +521
==========================================
- Hits 10249 9671 -578
- Misses 6934 8706 +1772
- Partials 611 751 +140 ☔ View full report in Codecov by Sentry. |
Summary
No longer include
features
dir in a modern.js monorepo project. This is a legacy, undocumented behavior and should not be used.🤖 Generated by Copilot at 904c855
This pull request simplifies and cleans up the code in the
@modern-js/app-tools
and@modern-js/utils
packages. It removes unused or deprecated functions, imports, dependencies, and tests. It also fixes some typos and improves the alias and environment detection logic. It adds a changeset file to document the changes.Details
🤖 Generated by Copilot at 904c855
@modern-js/app-tools
and@modern-js/utils
packages (link)inits.ts
andalias.ts
files in@modern-js/app-tools
and@modern-js/utils
packages (link, link)createBuilderInclude
function ininits.ts
file (link)validAlias
function fromalias.ts
file as alias config is handled bytsconfig.json
file (link)isProdProfile
andisFastRefresh
functions fromenv.ts
file as they are no longer used (link)isBrowser
function toenv.ts
file to check if the current environment is a browser (link)platform
export fromindex.ts
file and directly exportisNodeJS
andisBrowser
functions fromenv.ts
file (link)isModernjsMonorepo
function frommonorepo.ts
file as modernjs monorepo feature is deprecated (link)pluginDagSort.ts
file (link)alias.test.ts
,is.test.ts
, andmonorepo.test.ts
files (link, link, link, link, link, link)isPlatform.test.ts
file toisBrowser.test.ts
file and remove test forisNodeJS
function (link)pluginDagSort.test.ts
file (link)platform.ts
file as it is no longer needed (link)Related Issue
Checklist
pnpm run change
.