-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(module-tools): remove picomatch dep #4793
Conversation
🦋 Changeset detectedLatest commit: 6cd214d The changes in this PR will be included in the next version bump. This PR includes changesets to release 256 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4793 +/- ##
==========================================
- Coverage 57.59% 50.75% -6.85%
==========================================
Files 672 669 -3
Lines 17794 18622 +828
Branches 3876 4303 +427
==========================================
- Hits 10249 9452 -797
- Misses 6934 8445 +1511
- Partials 611 725 +114 ☔ View full report in Codecov by Sentry. |
Summary
🤖 Generated by Copilot at 6cd214d
This pull request removes an unused dependency (
picomatch
) and simplifies the external dependency resolution logic of the@modern-js/module-tools
package. This improves the code quality, performance, and package size of the module builder.Details
🤖 Generated by Copilot at 6cd214d
picomatch
import and dependency fromadapter.ts
andpackage.json
(link,link,link)picomatch
pattern matching with direct string comparison inadapterPlugin
function (link)umdGlobals
configuration object (link)@modern-js/module-tools
package (link)patch
keyword to indicate minor changes (link)Related Issue
Checklist
pnpm run change
.