-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(builder): display error progress bar when compile failed #4855
Merged
chenjiahan
merged 1 commit into
web-infra-dev:main
from
chenjiahan:builder_progress_1025
Oct 25, 2023
Merged
fix(builder): display error progress bar when compile failed #4855
chenjiahan
merged 1 commit into
web-infra-dev:main
from
chenjiahan:builder_progress_1025
Oct 25, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 5c1675a The changes in this PR will be included in the next version bump. This PR includes changesets to release 262 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
fireairforce
approved these changes
Oct 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
🤖 Generated by Copilot at 5c1675a
This pull request adds error handling and display to the
ProgressPlugin
for webpack. It updates thebar.ts
,bus.ts
, andtype.ts
files in the@modern-js/builder-webpack-provider
package, and adds a changeset file for the patch release.Details
🤖 Generated by Copilot at 5c1675a
@modern-js/builder-webpack-provider
(link)errorIcon
anderrorInfo
properties todefaultOption
andProps
type for customizing error display in progress bar (link, link)renderBar
function inbar.ts
to return different strings based onhasErrors
property (link, link)render
method inBus
class inbus.ts
to filter out null values and check for null before truncating (link)Related Issue
Checklist
pnpm run change
.