-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ssr): routerManifest may be a undefined #4857
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 592ceb5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 261 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
yimingjfe
approved these changes
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
🤖 Generated by Copilot at a1ae257
This pull request fixes some SSR bugs in the
@modern-js/runtime
package and refactors theLoadableCollector
class. It also adds a changeset file to document the patch version update and the bilingual description of the changes.Details
🤖 Generated by Copilot at a1ae257
@modern-js/runtime
package (link)existsAssets
to theLoadableCollector
class to return an array of asset paths that are already included in therouteManifest
object or undefined (link)existsAssets
method to simplify the logic of filtering out the redundant assets in theemitScriptAssets
andemitStyleAssets
methods of theLoadableCollector
class (link, link, link, link)routeManifest
andentryName
from the destructuring assignment of thethis.options
object in theemitScriptAssets
andemitStyleAssets
methods of theLoadableCollector
class (link, link)Related Issue
Checklist
pnpm run change
.