-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: upgrade react-router and remix #4873
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: f46e802 The changes in this PR will be included in the next version bump. This PR includes changesets to release 266 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
xuchaobei
previously approved these changes
Oct 27, 2023
clChenLiang
approved these changes
Oct 30, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
🤖 Generated by Copilot at 3acb7d8
Updated the code to use the latest version of
@remix-run/router
and its new API. Bumped thereact-router-dom
dependency version across several packages to match the peer dependency requirement of@remix-run/router
.Details
🤖 Generated by Copilot at 3acb7d8
react-router-dom
dependency version to6.17.0
in several packages to match the peer dependency requirement of@remix-run/router
and use the latest features and bug fixes (link, link, link, link)@remix-run/router
dependency version to1.10.0
inpackages/toolkit/runtime-utils/package.json
to use the new features and bug fixes (link)ErrorResponse
type withUNSAFE_ErrorResponseImpl
as the imported name inpackages/cli/plugin-data-loader/src/runtime/index.ts
andpackages/runtime/plugin-garfish/src/router/runtime/utils.tsx
, because theErrorResponse
type was renamed and exported as an internal implementation detail (link, link)isRouteErrorResponse
function as a public API to check if an error is an instance ofErrorResponse
, and use it instead oferror instanceof ErrorResponse
inpackages/cli/plugin-data-loader/src/runtime/index.ts
(link, link)response.headers
tounknown
and then toHeaders
inpackages/cli/plugin-data-loader/src/runtime/index.ts
, to avoid TypeScript errors when calling theconvertModernRedirectResponse
function, which expects aHeaders
argument, because theresponse
type was changed fromResponse
toResponse | RouteResponse
in the@remix-run/router
package, and theRouteResponse
type does not have aheaders
property (link)ErrorResponse
constructor withErrorResponseImpl
as the imported name inpackages/runtime/plugin-garfish/src/router/runtime/utils.tsx
, for the same reason as above (link)Related Issue
Checklist
pnpm run change
.