Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade react-router and remix #4873

Merged
merged 3 commits into from
Oct 30, 2023

Conversation

yimingjfe
Copy link
Member

@yimingjfe yimingjfe commented Oct 27, 2023

Summary

🤖 Generated by Copilot at 3acb7d8

Updated the code to use the latest version of @remix-run/router and its new API. Bumped the react-router-dom dependency version across several packages to match the peer dependency requirement of @remix-run/router.

Details

🤖 Generated by Copilot at 3acb7d8

  • Update react-router-dom dependency version to 6.17.0 in several packages to match the peer dependency requirement of @remix-run/router and use the latest features and bug fixes (link, link, link, link)
  • Update @remix-run/router dependency version to 1.10.0 in packages/toolkit/runtime-utils/package.json to use the new features and bug fixes (link)
  • Replace ErrorResponse type with UNSAFE_ErrorResponseImpl as the imported name in packages/cli/plugin-data-loader/src/runtime/index.ts and packages/runtime/plugin-garfish/src/router/runtime/utils.tsx, because the ErrorResponse type was renamed and exported as an internal implementation detail (link, link)
  • Add isRouteErrorResponse function as a public API to check if an error is an instance of ErrorResponse, and use it instead of error instanceof ErrorResponse in packages/cli/plugin-data-loader/src/runtime/index.ts (link, link)
  • Cast response.headers to unknown and then to Headers in packages/cli/plugin-data-loader/src/runtime/index.ts, to avoid TypeScript errors when calling the convertModernRedirectResponse function, which expects a Headers argument, because the response type was changed from Response to Response | RouteResponse in the @remix-run/router package, and the RouteResponse type does not have a headers property (link)
  • Replace ErrorResponse constructor with ErrorResponseImpl as the imported name in packages/runtime/plugin-garfish/src/router/runtime/utils.tsx, for the same reason as above (link)

Related Issue

Checklist

  • I have added changeset via pnpm run change.
  • I have updated the documentation.
  • I have added tests to cover my changes.

@changeset-bot
Copy link

changeset-bot bot commented Oct 27, 2023

🦋 Changeset detected

Latest commit: f46e802

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 266 packages
Name Type
@modern-js/plugin-data-loader Patch
@modern-js/plugin-garfish Patch
@modern-js/runtime Patch
@modern-js/runtime-utils Patch
@modern-js/plugin-ssg Patch
@modern-js/app-tools Patch
@e2e/garfish-dashboard-router-v6 Patch
@e2e/garfish-dashboard Patch
@e2e/garfish-main-router-v6 Patch
@e2e/garfish-main Patch
@e2e/garfish-table Patch
@modern-js/plugin-bff Patch
@modern-js/plugin-tailwindcss Patch
@modern-js/devtools-client Patch
@modern-js/devtools-mount Patch
@modern-js/plugin-devtools Patch
@modern-js/plugin-router-v5 Patch
@modern-js/plugin-testing Patch
@modern-js/storybook-builder Patch
@integration-test/alias-set Patch
api-service-koa Patch
app-docmuent Patch
async-entry-test Patch
tmp Patch
bff-express Patch
bff-koa Patch
integration-clean-dist-path Patch
integration-compatibility Patch
integration-custom-dist-path Patch
integration-custom-render Patch
integration-custom-template Patch
dev-server Patch
@integration-test/devtools Patch
integration-disable-html Patch
esbuild-transform-and-minify Patch
main-entry-name Patch
nonce Patch
routes Patch
file-based-router Patch
use-loader Patch
select-mul-entry-test Patch
select-one-entry-test Patch
server-config Patch
server-middleware Patch
server-hook-reqeust Patch
server-hook-response Patch
server-hook-router Patch
@integration-test/server-hook-reqeust Patch
server-prod Patch
@source-code-build/app-ts-loader Patch
@source-code-build/app Patch
ssg-fixtures-nested-routes Patch
ssg-fixtures-simple Patch
ssg-fixtures-web-server Patch
ssr-base-json-test Patch
ssr-base-test Patch
ssr-base-fallback-test Patch
init Patch
ssr-inline Patch
ssr-preload Patch
ssr-streaming-test Patch
swc-minify-css Patch
swc-minify-js Patch
transform-fail Patch
integration-tailwindcss-v2 Patch
integration-tailwindcss-v3-js-config Patch
integration-tailwindcss-v3-merge-config Patch
integration-tailwindcss-v3-ts-config Patch
integration-tailwindcss-v3 Patch
twin-macro-v2 Patch
twin-macro-v3 Patch
tmp-dir Patch
write-to-dist Patch
@modern-js/create-request Patch
@modern-js/prod-server Patch
@modern-js/server Patch
@modern-js/plugin-swc Patch
@modern-js/devtools-kit Patch
@modern-js/plugin-express Patch
@modern-js/plugin-koa Patch
@modern-js/plugin-polyfill Patch
@modern-js/plugin-server Patch
@modern-js/plugin-worker Patch
tests Patch
integration-asset-prefix Patch
integration-builder-plugins Patch
integration-copy-assets Patch
integration-config-async-config-test Patch
integration-basic-local-config Patch
integration-config-function-params Patch
integration-local-config-function Patch
swc-test-decorator-legacy Patch
swc-test-decorator Patch
@e2e/testing-plugin Patch
@modern-js/storybook Patch
@modern-js/builder-shared Patch
@modern-js/builder-rspack-provider Patch
@modern-js/builder-webpack-provider Patch
integration-tests-storybook Patch
@modern-js/core Patch
@modern-js/builder Patch
@modern-js/builder-plugin-esbuild Patch
@modern-js/builder-plugin-node-polyfill Patch
@modern-js/builder-plugin-stylus Patch
@modern-js/builder-plugin-swc Patch
@modern-js/builder-plugin-vue Patch
@modern-js/builder-plugin-vue2 Patch
@e2e/builder Patch
@e2e/builder-cli-rspack Patch
@e2e/builder-cli-vue Patch
@modern-js/builder-plugin-image-compress Patch
@modern-js/module-tools Patch
@e2e/builder-cli-webpack Patch
@modern-js/builder-cli Patch
@modern-js/doc-plugin-auto-sidebar Patch
@modern-js/plugin-changeset Patch
@modern-js/plugin-i18n Patch
@modern-js/plugin-lint Patch
@modern-js/plugin-proxy Patch
@modern-js/builder-doc Patch
@modern-js/main-doc Patch
@modern-js/module-tools-docs Patch
@modern-js/new-action Patch
@modern-js/sandpack-react Patch
@modern-js-app/eslint-config Patch
@modern-js/eslint-config Patch
@modern-js/tsconfig Patch
@modern-js/babel-plugin-module-resolver Patch
@modern-js/bff-core Patch
@modern-js/bff-runtime Patch
@modern-js/server-core Patch
@modern-js/server-utils Patch
@modern-js/plugin-module-babel Patch
@modern-js/plugin-module-banner Patch
@modern-js/plugin-module-import Patch
@modern-js/plugin-module-node-polyfill Patch
@modern-js/plugin-module-polyfill Patch
@modern-js/monorepo-tools Patch
@modern-js/create Patch
@modern-js/e2e Patch
@modern-js/node-bundle-require Patch
@modern-js/plugin Patch
@modern-js/types Patch
@modern-js/upgrade Patch
@modern-js/utils Patch
@modern-js/babel-compiler Patch
@scripts/build Patch
@scripts/check-changeset Patch
@scripts/jest-config Patch
@scripts/lint-package-json Patch
@scripts/prebundle Patch
@scripts/update-codesmith Patch
@scripts/update-rsbuild Patch
@scripts/update-rspress Patch
@scripts/vitest-config Patch
esbuild-integration Patch
integration-load-config Patch
alias-js-test Patch
alias-ts-test Patch
asset-limit-test Patch
asset-path-test Patch
asset-publicPath-test Patch
svgr-test Patch
auto-extension-commonjs-test Patch
auto-extension-type-module-test Patch
auto-external-test Patch
banner-footer-test Patch
build-type-test Patch
copy-test Patch
decorator-test Patch
global-vars-js-test Patch
global-vars-ts-test Patch
dts-test Patch
esbuild-options-test Patch
external-test Patch
format-cjs-test Patch
format-esm-test Patch
format-iife-test Patch
format-umd-test Patch
entry-test Patch
jsx-test Patch
metafile-test Patch
minify-test Patch
platform-test Patch
redirect-test Patch
data-url-test Patch
browser-false Patch
resolve-false Patch
ndoe-protocol-test Patch
lib1 Patch
lib2 Patch
lib3 Patch
condition-exports-test Patch
js-extensions-test Patch
main-fields-test Patch
shims-test Patch
module-tools-side-effects-test Patch
source-dir-test Patch
sourcemap-test Patch
splitting-test Patch
css-test Patch
less-test Patch
style-test Patch
postcss-test Patch
sass-test Patch
tailwindcss-test Patch
target-test Patch
transform-import Patch
transform-lodash Patch
tsconfig-test Patch
umdGlobals-test Patch
get-module-id-test Patch
dev-test Patch
build-platform-test Patch
build-preset-error-test Patch
build-preset-function-test Patch
build-preset-test Patch
build-preset-string-test Patch
integration-module-tools Patch
plugin-babel Patch
plugin-node-polyfill Patch
plugin-polyfill Patch
runtime Patch
entry Patch
@source-code-build/common Patch
@source-code-build/components Patch
@source-code-build/utils Patch
ssg Patch
ssr Patch
swc-integration Patch
tailwindcss-integration-test Patch
@e2e/webpack-builder-import-antd-v4 Patch
@e2e/webpack-builder-import-antd-v5 Patch
@e2e/webpack-builder-import-arco Patch
@e2e/webpack-builder-test-moment Patch
@e2e/builder-remove-prop-types Patch
@e2e/webpack-builder-source-map Patch
@e2e/builder-vue3 Patch
@e2e/builder-vue2 Patch
@e2e/garfish Patch
@modern-js/generator-common Patch
@modern-js/generator-plugin Patch
@modern-js/generator-utils Patch
@modern-js/bff-generator Patch
@modern-js/dependence-generator Patch
@modern-js/entry-generator Patch
@modern-js/generator-generator Patch
@modern-js/module-generator Patch
@modern-js/module-test-generator Patch
@modern-js/monorepo-generator Patch
@modern-js/mwa-generator Patch
@modern-js/router-v5-generator Patch
@modern-js/rspack-generator Patch
@modern-js/ssg-generator Patch
@modern-js/storybook-generator Patch
@modern-js/storybook-next-generator Patch
@modern-js/test-generator Patch
@modern-js/upgrade-generator Patch
@modern-js/generator-plugin-plugin Patch
@modern-js/base-generator Patch
@modern-js/changeset-generator Patch
@modern-js/packages-generator Patch
@modern-js/repo-generator Patch
@modern-js/server-generator Patch
@modern-js/tailwindcss-generator Patch
@modern-js/generator-cases Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@yimingjfe yimingjfe enabled auto-merge (squash) October 27, 2023 04:44
xuchaobei
xuchaobei previously approved these changes Oct 27, 2023
@yimingjfe yimingjfe merged commit f397649 into web-infra-dev:main Oct 30, 2023
7 checks passed
@caohuilin caohuilin mentioned this pull request Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants