-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: should not filter mf entrys when compiler is rspack #4886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 6492aed The changes in this PR will be included in the next version bump. This PR includes changesets to release 266 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
2heal1
approved these changes
Oct 31, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When Rspack is used as a bundler, there is no id in stats chunk and no other related attributes, so it's impossible to filter out initial entry chunks.
Rspack doesn't support mf now, so we disable the filter manner first.
🤖 Generated by Copilot at 6492aed
This pull request fixes a bug in the
RouterPlugin
class that caused incorrect routing for micro-frontend applications usingrspack
. It also adds a changeset file to document the bug fix for the@modern-js/app-tools
package.Details
🤖 Generated by Copilot at 6492aed
RouterPlugin
that filters out micro-frontend entry points when usingrspack
(link, link).changeset
folder to document the bug fix for@modern-js/app-tools
(link)Related Issue
Checklist
pnpm run change
.