Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: changed default export to named export #3353

Closed
wants to merge 1 commit into from
Closed

Conversation

hardfist
Copy link
Contributor

@hardfist hardfist commented May 30, 2023

BREAKING CHANGE: change rspack-dev-middleware & rspack-plugin-html default export to named export

fixes #2944 #2851

Related issue (if exists)

Summary

馃 Generated by Copilot at 65f6637

This pull request changes the export and import syntax of several packages in the rspack project to avoid using default exports, which can cause compatibility and consistency issues. The affected packages are @rspack/dev-middleware, @rspack/dev-server, and @rspack/plugin-html.

Walkthrough

馃 Generated by Copilot at 65f6637

  • Remove default exports and use named exports instead for rdm function and middleware module in @rspack/dev-middleware package (link)
  • Update import syntax for rdm function and getRspackMemoryAssets function in server.ts of @rspack/dev-server package to use named imports from @rspack/dev-middleware package (link)
  • Remove default export of HtmlRspackPlugin class in @rspack/plugin-html package and use named export instead (link)

@hardfist hardfist requested a review from ahabhgk as a code owner May 30, 2023 14:17
@github-actions github-actions bot added release: bug fix team The issue/pr is created by the member of Rspack. labels May 30, 2023
BREAKING CHANGE: change rspack-dev-middleware & rspack-plugin-html default export to named export
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change team The issue/pr is created by the member of Rspack.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@rspack/dev-middleware defalut export will cause node esm envirment crash.
1 participant