Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: panic in hmr cause by auxiliary_assets #7197

Merged
merged 2 commits into from
Jul 17, 2024
Merged

fix: panic in hmr cause by auxiliary_assets #7197

merged 2 commits into from
Jul 17, 2024

Conversation

SyMind
Copy link
Member

@SyMind SyMind commented Jul 17, 2024

Summary

fix: panic in hmr cause by auxiliary_assets

Prevent panic when a file is not found in assets. Aligns with webpack's behavior in https://github.com/webpack/webpack/blob/main/lib/stats/DefaultStatsFactoryPlugin.js#L1007.

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack. labels Jul 17, 2024
Copy link

netlify bot commented Jul 17, 2024

Deploy Preview for rspack ready!

Name Link
🔨 Latest commit e4e83c8
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/669775fad92d470008ab1d5f
😎 Deploy Preview https://deploy-preview-7197--rspack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@SyMind SyMind marked this pull request as ready for review July 17, 2024 06:21
@SyMind SyMind merged commit e7f5332 into main Jul 17, 2024
31 checks passed
@SyMind SyMind deleted the fix-hmr-panic branch July 17, 2024 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants