Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds <canvas> HTML element #1365

Merged
merged 13 commits into from
Jul 18, 2024
Merged

Adds <canvas> HTML element #1365

merged 13 commits into from
Jul 18, 2024

Conversation

petele
Copy link
Collaborator

@petele petele commented Jul 11, 2024 •
edited
Loading

Adds HTML <canvas> element

@petele
Adds <canvas> HTML element
fe7bfca 
Note: also removes `api.HTMLCanvasElement.transferControlToOffscreen` from the Off Screen Canvas file because that property is part of the canvas element.
@github-actions github-actions bot added the feature definition Creating or defining new features or groups of features. label Jul 11, 2024
@petele
Copy link
Collaborator Author

petele commented Jul 11, 2024

@ddbeck & @foolip - this one prob needs a little extra scrutiny for how I handled the transferToOffscreen method

@foolip
Copy link
Collaborator

foolip commented Jul 12, 2024

@petele I think transferControlToOffscreen ought to be in the offscreen canvas feature. It shipped with OffscreenCanvas and is one way of getting a OffscreenCanvas instance, in addition to the OffscreenCanvas constructor.

It's quite common for an API to have small bits on interfaces that mostly belong to another feature in this way. For example, https://w3c.github.io/selection-api/ has window.getSelection() and document.getSelection(), and those make sense together, not in whatever feature we end up putting Window and Document in.

foolip
foolip reviewed Jul 12, 2024
View reviewed changes
features/canvas.yml Outdated Show resolved Hide resolved
foolip
foolip reviewed Jul 12, 2024
View reviewed changes
features/canvas.yml Outdated Show resolved Hide resolved
petele and others added 3 commits July 15, 2024 16:17
@petele @ddbeck @foolip
Apply suggestions from code review
4dacd1f 
Co-authored-by: Daniel D. Beck <daniel@ddbeck.com>
Co-authored-by: Philip Jägenstedt <philip@foolip.org>
@petele
update with feedback
fad13cd
@petele
Merge branch 'main' into elem-canvas
2a40e20
@petele
Copy link
Collaborator Author

petele commented Jul 15, 2024

integrated feedback

@petele petele requested review from ddbeck and foolip July 16, 2024 13:53
@foolip foolip mentioned this pull request Jul 18, 2024
Open
foolip
foolip reviewed Jul 18, 2024
View reviewed changes
features/canvas.yml Outdated Show resolved Hide resolved
foolip
foolip reviewed Jul 18, 2024
View reviewed changes
features/canvas.yml Outdated Show resolved Hide resolved
foolip
foolip reviewed Jul 18, 2024
View reviewed changes
features/canvas.yml Outdated Show resolved Hide resolved
foolip
foolip reviewed Jul 18, 2024
View reviewed changes
features/canvas.yml Outdated Show resolved Hide resolved
@petele @foolip
Update features/canvas.yml
4876063 
Co-authored-by: Philip Jägenstedt <philip@foolip.org>
foolip
foolip reviewed Jul 18, 2024
View reviewed changes
features/canvas.yml Outdated Show resolved Hide resolved
@foolip foolip merged commit 9c8373b into web-platform-dx:main Jul 18, 2024
3 checks passed
@petele petele deleted the elem-canvas branch July 18, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@foolip foolip foolip approved these changes

@ddbeck ddbeck Awaiting requested review from ddbeck

Assignees
No one assigned
Labels
feature definition Creating or defining new features or groups of features.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@petele @foolip @ddbeck