Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add <title> element #1378

Merged
merged 4 commits into from
Jul 18, 2024
Merged

Add <title> element #1378

merged 4 commits into from
Jul 18, 2024

Conversation

petele
Copy link
Collaborator

@petele petele commented Jul 11, 2024

No description provided.

@github-actions github-actions bot added the feature definition Creating or defining new features or groups of features. label Jul 11, 2024
features/title.yml Outdated Show resolved Hide resolved
petele and others added 2 commits July 15, 2024 15:20
Co-authored-by: Patrick Brosset <patrickbrosset@gmail.com>
@petele
Copy link
Collaborator Author

petele commented Jul 15, 2024

Updated based on feedback.

Copy link
Contributor

@captainbrosset captainbrosset left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving with a comment to add compute_from.

features/title.yml Show resolved Hide resolved
@captainbrosset captainbrosset merged commit d935802 into web-platform-dx:main Jul 18, 2024
3 checks passed
@petele petele deleted the elem-title branch July 18, 2024 14:07
petele added a commit to petele/web-features that referenced this pull request Jul 18, 2024
* Add <title> element

* Update features/title.yml

Co-authored-by: Patrick Brosset <patrickbrosset@gmail.com>

* Add `compute_from`

---------

Co-authored-by: Patrick Brosset <patrickbrosset@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature definition Creating or defining new features or groups of features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants