Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add modulepreload feature for <link rel="modulepreload"> #291

Merged

Conversation

ddbeck
Copy link
Collaborator

@ddbeck ddbeck commented Aug 11, 2023

Some ideas for reviewing this:

  • Is this a reasonable identifier for the feature?
  • Is this a reasonable spec link for the feature? Is it a reasonable caniuse reference?
  • Are the mdn/browser-compat-data features plausible pieces of the feature as a whole?
  • Are any pieces missing?
  • Are any of the listed features later additions, part of a distinct sub feature, or otherwise excludable?

@ddbeck ddbeck force-pushed the 2023-08-11-add-feature-1-modulepreload branch from fd60989 to 2eaaf26 Compare August 11, 2023 10:28
@ddbeck ddbeck force-pushed the 2023-08-11-add-feature-1-modulepreload branch from 2eaaf26 to 9e5b9a6 Compare August 11, 2023 10:29
@ddbeck ddbeck added the feature definition Creating or defining new features or groups of features. label Aug 15, 2023
@foolip
Copy link
Collaborator

foolip commented Jan 31, 2024

@ddbeck can you review the name I added before merging this? It's definitely the most code-y name so far.

@ddbeck
Copy link
Collaborator Author

ddbeck commented Feb 2, 2024

Yeah, I think this is fine, for now. We'll probably want a guideline for attributes, once we hear from consumers about this kind of thing.

@ddbeck ddbeck merged commit 11ba65e into web-platform-dx:main Feb 2, 2024
2 checks passed
@ddbeck ddbeck deleted the 2023-08-11-add-feature-1-modulepreload branch February 2, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature definition Creating or defining new features or groups of features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants