Reusable Interop 20XX page #2944
Conversation
|
A question about the URL structure. If we have |
This is a good point, and it's an easy change. Now the path is |
There was a problem hiding this comment.
If I go to interop-2023, it gives me a mostly blank page.
We should handle years without data in webapp/static/interop-data.json gracefully.
A quick solution would be to just redirect back home.
A better solution would be to have a placeholder that lets the user know that the provided year is not supported.
|
Thanks for taking a look at this everyone - I'll be sure to address these in the near future 🙂 |
I took the quick way out and redirected to whatever the current interop year is. Hope that's alright 😬 |
Completely fine. Could you create an issue about this? This issue could be something we label for hacktoberfest. |
Sure! Issue created |
|
Great job on this @DanielRyanSmith !!! |
Co-authored-by: Kyle Ju <kyleju@google.com>
|
@KyleJu This is ready for your re-review, but it seems the debian install issue in the CI is no longer intermittent 🙁 |
|
|
This change refactors the Interop 2022 page to be reusable and functional for any year.
Staging environment link
Description of changes
wpt.fyi/interop-{year}.interop-2022.jshas been renamedinterop.jsand many references to "2022" as a specific year have been renamed.webapp/static/interop-data.json. Adding all fields for a given year will allow the year to be displayed (as long as the links given are valid)./interop-2021.