Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added testdriver automation for html/editing/focus/focus-02.html #10315

Merged
merged 1 commit into from
Apr 5, 2018
Merged

Added testdriver automation for html/editing/focus/focus-02.html #10315

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions html/editing/focus/focus-02-manual.html → html/editing/focus/focus-02.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,12 +7,8 @@
<meta assert="assert" content="Check if the key events received by document are targeted at the element when no element is focused">
<script src="/resources/testharness.js"></script>
<script src="/resources/testharnessreport.js"></script>
<h2>Steps:</h2>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have some convention about leaving manual steps in here so that they can be run without testdriver?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really. I think leaving the alone where they exist would be OK, but I wouldn't expect the instructions to stay working over time, or that they'd be added for new tests, so I'd perhaps slightly prefer removing them. WDYT?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think they should be removed.
When new tests are added with testdriver they generally aren't accompanied by manual steps incase they are run without testdriver, so I think we should stick to this convention. I also agree with what @foolip says with maintenance, but @jgraham you bring up a good point that makes me wonder whether we should even allow testdriver tests to be run in any other way than wpt run. I opened #10330 to further address this.

<ol>
<li>Press any key in [0-9a-zA-Z].</li>
</ol>
<h2>Expect results:</h2>
<p>PASS</p>
<script src="/resources/testdriver.js"></script>
<script src="/resources/testdriver-vendor.js"></script>
<div id="log"></div>
<script>

Expand All @@ -35,4 +31,8 @@ <h2>Expect results:</h2>
assert_equals(evt.target, document.body, "The keyup events must be targeted at the document's body.");
});

t1.step(function() {
test_driver.send_keys(document.body, "a");
});

</script>