html: Add a test for _charset_. #10623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HTML spec change: whatwg/html#3645 URL spec change: whatwg/url#382
This was referenced Apr 25, 2018
annevk
reviewed
Apr 25, 2018
| <body> | ||
|
|
||
| <iframe name="frame1"></iframe> | ||
| <form accept-charset="windows-1252" target="frame1" action="/common/blank.html"> |
There was a problem hiding this comment.
Maybe make this value "iso-8859-1" so we can see that the bit of mapping that to "windows-1252" is implemented as well.
| <head> | ||
| <meta charset="utf-8"> | ||
| <link rel="help" href="https://html.spec.whatwg.org/multipage/form-control-infrastructure.html#constructing-the-form-data-set"> | ||
| <link rel="help" href="https://fetch.spec.whatwg.org/#ref-for-utf-8"> |
There was a problem hiding this comment.
https://xhr.spec.whatwg.org/#dom-formdata is the reference you want here I think, but I think it's better to just leave out <link rel=help> as they often go out-of-date.
There was a problem hiding this comment.
I changed this to https://fetch.spec.whatwg.org/#concept-bodyinit-extract, and added https://xhr.spec.whatwg.org/#dom-formdata too.
I want to mention Fetch spec here because it explains _charset_ value for new FormData(form) is "UTF-8".
annevk
approved these changes
Apr 27, 2018
annevk
pushed a commit
to whatwg/html
that referenced
this pull request
Apr 27, 2018
This makes the algorithms match Chrome, Firefox, and Safari. Change to the URL Standard: whatwg/url#382. Tests: web-platform-tests/wpt#10623. Fixes #3560.
alice
pushed a commit
to alice/html
that referenced
this pull request
Jan 8, 2019
This makes the algorithms match Chrome, Firefox, and Safari. Change to the URL Standard: whatwg/url#382. Tests: web-platform-tests/wpt#10623. Fixes whatwg#3560.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HTML spec change: whatwg/html#3645
URL spec change: whatwg/url#382