[idlharness.js] Support subsetTestByKey in idlharness #11414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will this not easily result in subtests moving, given idlharness.js adding/removing tests will change the number produced? A bit painful for expectation management, IMO. |
|
Yes. Could split more semantically. |
|
@gsnedders PTAL |
zcorpan
changed the title
gsnedders
approved these changes
Jun 12, 2018
|
One quick thought: I wonder if |
|
There are no owners for this pull request. Please reach out on W3C's irc server (irc.w3.org, port 6665) on channel #testing (web client) to get help with this. Thank you! |
|
Renamed to key. |
zcorpan
changed the title
zcorpan
added a commit
that referenced
this pull request
Jun 21, 2018
gsnedders
pushed a commit
that referenced
this pull request
Jun 21, 2018
lukebjerring
pushed a commit
to lukebjerring/wpt
that referenced
this pull request
Jun 26, 2018
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Jul 11, 2018
…y function, a=testonly Automatic update from web-platform-tests[docs] Document subsetTestByKey() utility function (#11610) Added in web-platform-tests/wpt#11414 -- wpt-commits: 973012935e322f9238878a0246ea9937a68c37b6 wpt-pr: 11610
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Oct 3, 2019
…y function, a=testonly Automatic update from web-platform-tests[docs] Document subsetTestByKey() utility function (#11610) Added in web-platform-tests/wpt#11414 -- wpt-commits: 973012935e322f9238878a0246ea9937a68c37b6 wpt-pr: 11610 UltraBlame original commit: 8c42f515c0e37082762d79a2bcc9a5ecd7c0f7db
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Oct 3, 2019
…y function, a=testonly Automatic update from web-platform-tests[docs] Document subsetTestByKey() utility function (#11610) Added in web-platform-tests/wpt#11414 -- wpt-commits: 973012935e322f9238878a0246ea9937a68c37b6 wpt-pr: 11610 UltraBlame original commit: 8c42f515c0e37082762d79a2bcc9a5ecd7c0f7db
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Oct 3, 2019
…y function, a=testonly Automatic update from web-platform-tests[docs] Document subsetTestByKey() utility function (#11610) Added in web-platform-tests/wpt#11414 -- wpt-commits: 973012935e322f9238878a0246ea9937a68c37b6 wpt-pr: 11610 UltraBlame original commit: 8c42f515c0e37082762d79a2bcc9a5ecd7c0f7db
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11413.