HTML: default style for fieldset #12501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
requested review from
annevk,
domenic,
foolip,
jdm,
jgraham,
sideshowbarker and
zqzhang
zcorpan
added a commit
to whatwg/html
that referenced
this pull request
Aug 15, 2018
WebKit/Chromium/EdgeHTML have 0.75em left/right padding and 0.625em bottom padding. Gecko has it the other way around. Fixes #3921. Tests: web-platform-tests/wpt#12501
annevk
pushed a commit
to whatwg/html
that referenced
this pull request
Aug 16, 2018
WebKit/Chromium/EdgeHTML have 0.75em left/right padding and 0.625em bottom padding. Gecko has it the other way around. Tests: web-platform-tests/wpt#12501. Fixes #3921.
|
@annevk the spec change was merged. Can you review this also? |
annevk
approved these changes
Aug 17, 2018
| padding-inline-start: 0.75em; | ||
| */ | ||
| min-width: min-content; | ||
| /* TODO change the above to min-inline-size per https://github.com/whatwg/html/pull/3914 */ |
There was a problem hiding this comment.
Should this be changed already? I think Fx is close to shipping this at least.
There was a problem hiding this comment.
min-inline-size is not yet supported in Safari or Edge, but I can update the comment.
mustaqahmed
pushed a commit
to mustaqahmed/html
that referenced
this pull request
Feb 15, 2019
WebKit/Chromium/EdgeHTML have 0.75em left/right padding and 0.625em bottom padding. Gecko has it the other way around. Tests: web-platform-tests/wpt#12501. Fixes whatwg#3921.
mustaqahmed
pushed a commit
to mustaqahmed/html
that referenced
this pull request
Feb 15, 2019
WebKit/Chromium/EdgeHTML have 0.75em left/right padding and 0.625em bottom padding. Gecko has it the other way around. Tests: web-platform-tests/wpt#12501. Fixes whatwg#3921.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See whatwg/html#3921.