Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTML: window.document and discarded browsing contexts #15788

Merged
merged 1 commit into from
Mar 13, 2019
Merged

HTML: window.document and discarded browsing contexts #15788

merged 1 commit into from
Mar 13, 2019

Conversation

annevk
Copy link
Member

@annevk annevk commented Mar 12, 2019

No description provided.

domenic
domenic approved these changes Mar 12, 2019
View reviewed changes
Copy link
Member

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but as always it'd also be interesting to test window.close()-based discarding

@annevk annevk merged commit 1c31e42 into master Mar 13, 2019
@annevk annevk deleted the annevk/window.document-discard-bc branch March 13, 2019 07:59
@annevk
Copy link
Member Author

annevk commented Mar 13, 2019

I might look into creating an abstraction later I suppose.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@domenic domenic domenic approved these changes

@foolip foolip Awaiting requested review from foolip

@jdm jdm Awaiting requested review from jdm

@jgraham jgraham Awaiting requested review from jgraham

@zcorpan zcorpan Awaiting requested review from zcorpan

@zqzhang zqzhang Awaiting requested review from zqzhang

Assignees

@foolip foolip

Labels
html
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@annevk @domenic @foolip @wpt-pr-bot