Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite self.html as an any.js test. #18228

Merged
merged 1 commit into from Feb 25, 2020
Merged

Rewrite self.html as an any.js test. #18228

merged 1 commit into from Feb 25, 2020

Conversation

Ms2ger
Copy link
Contributor

@Ms2ger Ms2ger commented Aug 1, 2019

Bonus: this adds coverage for shared and service workers.

@annevk
Copy link
Member

annevk commented Aug 5, 2019

Does the tooling do the .https. magic for service workers?

@Ms2ger
Copy link
Contributor Author

Ms2ger commented Aug 6, 2019

Does the tooling do the .https. magic for service workers?

Looking at another test that does it: https://wpt.fyi/results/workers?label=master&label=experimental&q=worker-replace-global-constructor. It seems to all work fine.

@jgraham
Copy link
Contributor

jgraham commented Aug 6, 2019

You can also confirm that this does what you expect by looking at the wpt.fyi links in the status checks e.g. https://wpt.fyi/results/workers/interfaces/WorkerGlobalScope?sha=8f6fa9cfe0

@annevk
Copy link
Member

annevk commented Aug 6, 2019

Hmm, so does .serviceworker. imply .https. these days? https://web-platform-tests.org/writing-tests/general-guidelines.html does not mention it.

@jgraham
Copy link
Contributor

jgraham commented Aug 6, 2019

Yeah, see https://github.com/web-platform-tests/wpt/blob/master/tools/manifest/sourcefile.py#L79 It was fixed in #6792 I assume the docs don't mention it because it "just works", but you're right that they should.

@annevk
Copy link
Member

annevk commented Aug 6, 2019

Well, that commit added https to the filename as well, but it seems that's no longer the case so there was another change made since then that did not address the documentation.

annevk added a commit that referenced this pull request Aug 6, 2019
jgraham pushed a commit that referenced this pull request Aug 6, 2019
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Aug 9, 2019
…ttps these days, a=testonly

Automatic update from web-platform-tests
Documentation: .serviceworker implies .https these days (#18295)

See discussion at web-platform-tests/wpt#18228.

--

wpt-commits: a4ddde6e6cbcc3566bda88d953fad8a25c5ee259
wpt-pr: 18295
xeonchen pushed a commit to xeonchen/gecko that referenced this pull request Aug 10, 2019
…ttps these days, a=testonly

Automatic update from web-platform-tests
Documentation: .serviceworker implies .https these days (#18295)

See discussion at web-platform-tests/wpt#18228.

--

wpt-commits: a4ddde6e6cbcc3566bda88d953fad8a25c5ee259
wpt-pr: 18295
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this pull request Oct 4, 2019
…ttps these days, a=testonly

Automatic update from web-platform-tests
Documentation: .serviceworker implies .https these days (#18295)

See discussion at web-platform-tests/wpt#18228.

--

wpt-commits: a4ddde6e6cbcc3566bda88d953fad8a25c5ee259
wpt-pr: 18295

UltraBlame original commit: fc648fd1ff6cf7c5a9c74cb8a04ee7f0603df930
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this pull request Oct 4, 2019
…ttps these days, a=testonly

Automatic update from web-platform-tests
Documentation: .serviceworker implies .https these days (#18295)

See discussion at web-platform-tests/wpt#18228.

--

wpt-commits: a4ddde6e6cbcc3566bda88d953fad8a25c5ee259
wpt-pr: 18295

UltraBlame original commit: fc648fd1ff6cf7c5a9c74cb8a04ee7f0603df930
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this pull request Oct 4, 2019
…ttps these days, a=testonly

Automatic update from web-platform-tests
Documentation: .serviceworker implies .https these days (#18295)

See discussion at web-platform-tests/wpt#18228.

--

wpt-commits: a4ddde6e6cbcc3566bda88d953fad8a25c5ee259
wpt-pr: 18295

UltraBlame original commit: fc648fd1ff6cf7c5a9c74cb8a04ee7f0603df930
@gsnedders gsnedders closed this Jan 24, 2020
@gsnedders gsnedders deleted the worker-self branch January 24, 2020 18:07
@gsnedders gsnedders restored the worker-self branch January 24, 2020 18:46
@Hexcles Hexcles reopened this Jan 24, 2020
Bonus: this adds coverage for shared and service workers.
@Ms2ger Ms2ger merged commit 342de36 into master Feb 25, 2020
@Ms2ger Ms2ger deleted the worker-self branch February 25, 2020 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants