Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

html: Add a test for 'autofocus' as a global attribute #18558

Merged
merged 4 commits into from
Sep 3, 2019

Conversation

tkent-google
Copy link
Contributor

@tkent-google tkent-google commented Aug 20, 2019

@tkent-google
Copy link
Contributor Author

html/semantics/forms/autofocus/ should be moved to html/interaction/focus/autofocus/. I'd like to do it in a separated PR.

Copy link
Member

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with nit.

html/semantics/forms/autofocus/supported-elements.html Outdated Show resolved Hide resolved
// doesn't work well.
async function waitUntilStableAutofocusState(test) {
// TODO: Update this for https://github.com/web-platform-tests/wpt/pull/17929
await timeOut(test, 100);
Copy link
Member

@zcorpan zcorpan Aug 22, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe I'm missing something, but won't this just cause the test to always time out before the rest of the test gets run?

https://github.com/web-platform-tests/wpt/pull/17929/files#diff-c05e2b49bb15cca07f18649490b4e74eR25 has a different implementation.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I misremembered what step_timeout does. Never mind.

Still, which of this PR and #17929 has the implementation you want?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still, which of this PR and #17929 has the implementation you want?

One in #17929 is the final implementation.
However, it's not correct until the specification change for #17929 is merged.

@tkent-google
Copy link
Contributor Author

Added a test for SVG elements.
w3c/svgwg#728

@zcorpan zcorpan assigned AmeliaBR and unassigned jgraham Aug 30, 2019
@zcorpan
Copy link
Member

zcorpan commented Aug 30, 2019

Reassigning to @AmeliaBR to review the SVG test

@domenic
Copy link
Member

domenic commented Aug 30, 2019

The HTML side of this has been merged into the spec.

Copy link
Contributor

@AmeliaBR AmeliaBR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a little more work to adapt the script to SVG elements, because those elements are only rendered within an SVG layout context.

svg/struct/scripted/autofocus-attribute.svg Outdated Show resolved Hide resolved
svg/struct/scripted/autofocus-attribute.svg Show resolved Hide resolved
svg/struct/scripted/autofocus-attribute.svg Outdated Show resolved Hide resolved
svg/struct/scripted/autofocus-attribute.svg Outdated Show resolved Hide resolved
svg/struct/scripted/autofocus-attribute.svg Outdated Show resolved Hide resolved
Copy link
Contributor

@AmeliaBR AmeliaBR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The SVG tests look good to me now.

@zcorpan zcorpan assigned domenic and unassigned AmeliaBR Sep 2, 2019
@tkent-google tkent-google merged commit cfb69fe into master Sep 3, 2019
@tkent-google tkent-google deleted the tkent-autofocus-global branch September 3, 2019 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants