Fix ordering of script elements in the-script-element/module/module-vs-script-*.html tests
#19117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As for title in `html/semantics/scripting-1/the-script-element/module/module-vs-script-1.html`, it says "Once as module script, once as classic script" and the title of `html/semantics/scripting-1/the-script-element/module/module-vs-script-2.html` says "Once as classic script, once as module script". So, it should be reasonable to make the second test have script elements order in classic and then module.
wpt-pr-bot
requested review from
annevk,
domenic,
foolip,
jdm,
jgraham,
zcorpan and
zqzhang
Ms2ger
approved these changes
Sep 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As for title in
html/semantics/scripting-1/the-script-element/module/module-vs-script-1.html, it says "Once as module script, once as classic script" and the title ofhtml/semantics/scripting-1/the-script-element/module/module-vs-script-2.htmlsays "Once as classic script, once as module script". So, it should be reasonable to make the second test have script elementsorder in classic and then module.