-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update reversing-an-animation test #20559
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The review process for this patch is being conducted in the Chromium project.
d7f11da
to
0f28b92
Compare
Double rAF start of the test to avoid starting the animation while too busy to handle updates in a timely manner. Bug: 1029541 Change-Id: I3e0e665f0b4b9dd6f6a87d84d207b0c18a1b51c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946668 Commit-Queue: Kevin Ellis <kevers@chromium.org> Reviewed-by: Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#721486}
0f28b92
to
8868eb3
Compare
Looks like the test was flaky:
Admin merging, and will ping CL author as an FYI. |
The test actually pretty flaky on Firefox, https://bugzilla.mozilla.org/show_bug.cgi?id=1601322. I suppose the test expects that the snapshot is taken after the animation in question finished? If so, can we wait for an animation finish event instead of the flaky 900ms delay? |
@stephenmcgruer can you please this issue bounce to the test author Kevin? I couldn't find his account on github. |
I think Kevin might be @kevers-google |
@hiikezoe - thanks for bringing this to my attention. This is being tracked in https://crbug.com/1029543 |
Double rAF start of the test to avoid starting the animation while too
busy to handle updates in a timely manner.
Bug: 1029541
Change-Id: I3e0e665f0b4b9dd6f6a87d84d207b0c18a1b51c2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946668
Commit-Queue: Kevin Ellis <kevers@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721486}