-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Origin isolation: test location.href access #24259
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Jun 19, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The review process for this patch is being conducted in the Chromium project.
location.href access is one of the things that is guarded by the "same-origin domain" check, but it goes down a different code path than generic synchronous property access such as we test with window.document. So, it's worth testing it additionally. Bug: 1042415 Change-Id: I92fc222f895bf25fc1767e7ffddd3d7f7f1f1e86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255102 Reviewed-by: James MacLean <wjmaclean@chromium.org> Commit-Queue: Domenic Denicola <domenic@chromium.org> Cr-Commit-Position: refs/heads/master@{#780787}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2255102
branch
from
June 22, 2020 16:04
b3c1801
to
72fbef1
Compare
Seeing flakiness on Chrome Dev: Unstable results
|
Filed crbug.com/1097980 @Hexcles could you please admin merge this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
location.href access is one of the things that is guarded by the
"same-origin domain" check, but it goes down a different code path
than generic synchronous property access such as we test with
window.document. So, it's worth testing it additionally.
Bug: 1042415
Change-Id: I92fc222f895bf25fc1767e7ffddd3d7f7f1f1e86
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255102
Reviewed-by: James MacLean <wjmaclean@chromium.org>
Commit-Queue: Domenic Denicola <domenic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#780787}