Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

XPathNSResolver: Add "xml" prefix test #24371

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

XPathNSResolver: Add "xml" prefix test #24371

wants to merge 2 commits into from

Conversation

shvaikalesh
Copy link
Member

@shvaikalesh shvaikalesh commented Jun 28, 2020 •
edited
Loading

@shvaikalesh shvaikalesh mentioned this pull request Jun 28, 2020
Closed
tkent-google
tkent-google requested changes Jun 29, 2020
View reviewed changes
Copy link
Contributor

@tkent-google tkent-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tested behavior doesn't match to the current specification.
We should make a specification change first.

@shvaikalesh
Copy link
Member Author

DOM 3 XPath spec is very outdated and quite vague.
I am not absolutely positive that what is being tested is "implicit xml prefix".
whatwg/dom#67 is tracking issue to rewrite the spec.

@gsnedders
Copy link
Member

We've landed a bunch of DOM XPath stuff as tentative tests, which IMO is fine here if there's some agreement from Blink/WebKit that this is a change we should try to make.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tkent-google tkent-google tkent-google requested changes

@deniak deniak Awaiting requested review from deniak

@zqzhang zqzhang Awaiting requested review from zqzhang

Requested changes must be addressed to merge this pull request.

Assignees

@zqzhang zqzhang

Labels
domxpath wg-dom
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

lookupNamespaceURI('xml')
5 participants
@shvaikalesh @gsnedders @tkent-google @zqzhang @wpt-pr-bot