Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix COEP reporting tests #25177

Merged
merged 5 commits into from
Aug 22, 2020
Merged

Fix COEP reporting tests #25177

merged 5 commits into from
Aug 22, 2020

Conversation

yutakahirano
Copy link
Contributor

This is for whatwg/html#5848.

@yutakahirano yutakahirano mentioned this pull request Aug 21, 2020
Merged
3 tasks
@wpt-pr-bot wpt-pr-bot temporarily deployed to wpt-preview-25177 August 21, 2020 10:45 Inactive
domenic
domenic approved these changes Aug 21, 2020
View reviewed changes
Copy link
Member

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found a typo, but otherwise looks good...

html/cross-origin-embedder-policy/reporting-subresource-corp.https.html Outdated Show resolved Hide resolved
@yutakahirano @domenic
Update html/cross-origin-embedder-policy/reporting-subresource-corp.h…
b7c0966 
…ttps.html

Co-authored-by: Domenic Denicola <d@domenic.me>
@yutakahirano yutakahirano merged commit 8b381a6 into master Aug 22, 2020
@yutakahirano yutakahirano deleted the yhirano/coep-report-properties branch August 22, 2020 01:01
pull bot pushed a commit to Alan-love/chromium that referenced this pull request Aug 24, 2020
@yutakahirano
Add expectation for wpt/html/COEP/reporting-to-endpoint.https.html
7dcd00f 
web-platform-tests/wpt#25177 modified
wpt/html/COEP/reporting-to-endpoint.https.html, and that blocks
the WPT autoroller because the output depends on onetime tokens.
See https://chromium-review.googlesource.com/c/chromium/src/+/2371035
for example.

Add a failure expectation to unblock the autoroller.

Bug: 1119676
Change-Id: I99e17bee60d73ce6d2645693e8e48406092deb49
No-Try: True
Tbr: foolip@google.com
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2370685
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#800914}
chromium-wpt-export-bot pushed a commit that referenced this pull request Aug 25, 2020
@yutakahirano @chromium-wpt-export-bot
Augment COEP violation report
3d7c89f 
This implements whatwg/html#5848.

 - Add "blockedURL" (we'll keep "blocked-url" for some time)
 - Add "disposition".
 - Add "destination".

There were subtle bugs in WPTs
(#25177). Fix them.

Bug: 1119676
Change-Id: I9b83f18d9881b2742bafd88405b57645a67cac49
@chromium-wpt-export-bot chromium-wpt-export-bot mentioned this pull request Aug 25, 2020
Merged
chromium-wpt-export-bot pushed a commit that referenced this pull request Aug 25, 2020
@yutakahirano @chromium-wpt-export-bot
Augment COEP violation report
62d7dbe 
This implements whatwg/html#5848.

 - Add "blockedURL" (we'll keep "blocked-url" for some time).
 - Add "disposition".
 - Add "destination".

There are subtle bugs in WPTs
(#25177). Fix them.

Bug: 1119676
Change-Id: I9b83f18d9881b2742bafd88405b57645a67cac49
chromium-wpt-export-bot pushed a commit that referenced this pull request Aug 26, 2020
@yutakahirano @chromium-wpt-export-bot
Augment COEP violation report
b117625 
This implements whatwg/html#5848.

 - Add "blockedURL" (we'll keep "blocked-url" for some time).
 - Add "disposition".
 - Add "destination".

There are subtle bugs in WPTs
(#25177). Fix them.

Bug: 1119676
Change-Id: I9b83f18d9881b2742bafd88405b57645a67cac49
chromium-wpt-export-bot pushed a commit that referenced this pull request Aug 26, 2020
@yutakahirano @chromium-wpt-export-bot
Augment COEP violation report
0ae3fb1 
This implements whatwg/html#5848.

 - Add "blockedURL" (we'll keep "blocked-url" for some time).
 - Add "disposition".
 - Add "destination".

There are subtle bugs in WPTs
(#25177). Fix them.

Bug: 1119676
Change-Id: I9b83f18d9881b2742bafd88405b57645a67cac49
chromium-wpt-export-bot pushed a commit that referenced this pull request Aug 27, 2020
@yutakahirano @chromium-wpt-export-bot
Augment COEP violation report
7362041 
This implements whatwg/html#5848.

 - Add "blockedURL" (we'll keep "blocked-url" for some time).
 - Add "disposition".
 - Add "destination".

There are subtle bugs in WPTs
(#25177). Fix them.

Bug: 1119676
Change-Id: I9b83f18d9881b2742bafd88405b57645a67cac49
blueboxd pushed a commit to blueboxd/chromium-legacy that referenced this pull request Aug 27, 2020
@yutakahirano
Augment COEP violation report
ad15c8c 
This implements whatwg/html#5848.

 - Add "blockedURL" (we'll keep "blocked-url" for some time).
 - Add "disposition".
 - Add "destination".

There are subtle bugs in WPTs
(web-platform-tests/wpt#25177). Fix them.

Bug: 1119676
Change-Id: I9b83f18d9881b2742bafd88405b57645a67cac49
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2373970
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Reviewed-by: Domenic Denicola <domenic@chromium.org>
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#802161}
chromium-wpt-export-bot pushed a commit that referenced this pull request Aug 27, 2020
@yutakahirano @chromium-wpt-export-bot
Augment COEP violation report
1a8ba9d 
This implements whatwg/html#5848.

 - Add "blockedURL" (we'll keep "blocked-url" for some time).
 - Add "disposition".
 - Add "destination".

There are subtle bugs in WPTs
(#25177). Fix them.

Bug: 1119676
Change-Id: I9b83f18d9881b2742bafd88405b57645a67cac49
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2373970
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Reviewed-by: Domenic Denicola <domenic@chromium.org>
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#802161}
chromium-wpt-export-bot pushed a commit that referenced this pull request Aug 27, 2020
@yutakahirano @chromium-wpt-export-bot
Augment COEP violation report
792570a 
This implements whatwg/html#5848.

 - Add "blockedURL" (we'll keep "blocked-url" for some time).
 - Add "disposition".
 - Add "destination".

There are subtle bugs in WPTs
(#25177). Fix them.

Bug: 1119676
Change-Id: I9b83f18d9881b2742bafd88405b57645a67cac49
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2373970
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Reviewed-by: Domenic Denicola <domenic@chromium.org>
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#802161}
mjfroman pushed a commit to mjfroman/moz-libwebrtc-third-party that referenced this pull request Oct 14, 2022
@yutakahirano
Add expectation for wpt/html/COEP/reporting-to-endpoint.https.html
c12dc97 
web-platform-tests/wpt#25177 modified
wpt/html/COEP/reporting-to-endpoint.https.html, and that blocks
the WPT autoroller because the output depends on onetime tokens.
See https://chromium-review.googlesource.com/c/chromium/src/+/2371035
for example.

Add a failure expectation to unblock the autoroller.

Bug: 1119676
Change-Id: I99e17bee60d73ce6d2645693e8e48406092deb49
No-Try: True
Tbr: foolip@google.com
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2370685
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#800914}
GitOrigin-RevId: 7dcd00f40fabc72e741d9db6ec78861944eb3ddc
mjfroman pushed a commit to mjfroman/moz-libwebrtc-third-party that referenced this pull request Oct 14, 2022
@yutakahirano
Augment COEP violation report
9d29379 
This implements whatwg/html#5848.

 - Add "blockedURL" (we'll keep "blocked-url" for some time).
 - Add "disposition".
 - Add "destination".

There are subtle bugs in WPTs
(web-platform-tests/wpt#25177). Fix them.

Bug: 1119676
Change-Id: I9b83f18d9881b2742bafd88405b57645a67cac49
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2373970
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Reviewed-by: Domenic Denicola <domenic@chromium.org>
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#802161}
GitOrigin-RevId: ad15c8ce99ced75169e377b7aa88302b98b47d2a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@domenic domenic domenic approved these changes

@annevk annevk Awaiting requested review from annevk

@arturjanc arturjanc Awaiting requested review from arturjanc

@foolip foolip Awaiting requested review from foolip

@hemeryar hemeryar Awaiting requested review from hemeryar

@jdm jdm Awaiting requested review from jdm

@jgraham jgraham Awaiting requested review from jgraham

@jugglinmike jugglinmike Awaiting requested review from jugglinmike

@mikewest mikewest Awaiting requested review from mikewest

@ParisMeuleman ParisMeuleman Awaiting requested review from ParisMeuleman

@valenting valenting Awaiting requested review from valenting

@zcorpan zcorpan Awaiting requested review from zcorpan

@zqzhang zqzhang Awaiting requested review from zqzhang

Assignees

@jugglinmike jugglinmike

Labels
html
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@yutakahirano @domenic @jugglinmike @wpt-pr-bot @moz-wptsync-bot