cross-origin-opener-policy/resource-popup.https.html makes incorrect …

[cdumez]

…assumption about win.location.href

The test expects that win.location.href starts returning something else than "about:blank" after closing.
While this is true in Firefox and Blink, none of the browser engines actually agree on this (Firefox
returns the empty string, Chrome returns undefined and Safari returns "about:blank").

Per the specification, it seems returning "about:blank" after a window is closed is the expected behavior,
see whatwg/html#6899. I am fixing thus fixing the test so that it can run in
all browsers by checking if "the window is closed" OR "href is no longer about:blank because it was
navigated".

[foolip]

@cdumez with this change, will there be any tests failing in Chrome and Firefox due to their bug(s)? If not, could the test be copied and minified to just test that, which would be a testing passing only in Safari?

[mikewest]

@ParisMeuleman is OOO for a while, perhaps @ArthurSonzogni or @antosart can take a look at this in the meantime?

[mikewest]

Actually, the test change seems clearly reasonable. The underlying behavior change is what folks ought to take a look at. I'll approve this, and CC folks on the HTML issue.

[annevk]

Interesting, if true I guess we should wait for .closed and then assert the about:blankness.

[cdumez]

@cdumez with this change, will there be any tests failing in Chrome and Firefox due to their bug(s)? If not, could the test be copied and minified to just test that, which would be a testing passing only in Safari?

My changes to this test should not make the test fail in Firefox on Chrome. It merely makes it runnable in Safari.

However, the fact that Firefox and Chrome do not match the spec and location.href does not return 'about:blank' after the browsing context is gone is causing failures on the following existing tests:

• https://wpt.live/html/browsers/history/the-location-interface/no-browsing-context.window.html
• https://wpt.live/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/url.window.html