Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for CSS Color 5 color-mix() #31902

Merged
merged 1 commit into from
Dec 13, 2021

Conversation

weinig
Copy link
Contributor

@weinig weinig commented Dec 5, 2021

Tests for parsing and serializing color-mix().

@nt1m
Copy link
Member

nt1m commented Dec 5, 2021

@emilio might be a good reviewer here since he worked on color-mix in Gecko.

@nt1m
Copy link
Member

nt1m commented Dec 5, 2021

@weinig
Copy link
Contributor Author

weinig commented Dec 5, 2021

Because I forgot to mention it in the description, this is a wpt-ified version of the color-mix() tests in WebKit's layout tests that I wrote, https://github.com/WebKit/WebKit/blob/main/LayoutTests/fast/css/parsing-color-mix.html.

@foolip foolip merged commit ddb4568 into web-platform-tests:master Dec 13, 2021
@svgeesus
Copy link
Contributor

@nt1m

This is the test Gecko contributed: https://github.com/web-platform-tests/wpt/tree/master/css/css-color/color-mix-basic-001.tentative.html

That test should no longer be marked tentative. It references w3c/csswg-drafts#6066 which is closed, and the test case is conformant to the way the issue was resolved.

@nt1m
Copy link
Member

nt1m commented Dec 14, 2021

@svgeesus #32064

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants