Test automation for custom handlers #35792
Conversation
wpt-pr-bot
added
html
infra
testdriver.js
wptrunner
wpt-pr-bot
requested review from
annevk,
DanielRyanSmith,
domenic,
foolip,
jdm,
jgraham and
zqzhang
|
Since this change touches both, 'resources' and 'tools' folders it'd required an RFC proposal to be discussed and approved. See web-platform-tests/rfcs#121 for details. |
The PR#8267 [1] for the HTML spec introduced a new WebDriver extension command to allow testing automation for the registerProtocolHandler method of the Custom Handlers API. This CL adds support in ChromeDriver for such extension command. See also the Web Platform Test PR [2] and RFC [3] for further details. The extension command relies on a new CDP command implemented in a different CL [4]. [1] whatwg/html#8267 [2] web-platform-tests/wpt#35792 [3] web-platform-tests/rfcs#121 [4] https://crrev.com/c/4203529 Bug: 1359103 Change-Id: Ifd4385815ab30a40f46c2f083dc9604024060613 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4200660 Reviewed-by: Vladimir Nechaev <nechaev@chromium.org> Commit-Queue: Javier Fernandez <jfernandez@igalia.com> Cr-Commit-Position: refs/heads/main@{#1100968}
...system-state-and-capabilities/the-navigator-object/protocol-handler-fragment-nosw.https.html
Outdated
Show resolved
Hide resolved
...system-state-and-capabilities/the-navigator-object/protocol-handler-fragment-nosw.https.html
Show resolved
Hide resolved
I thought about it, tbh. They might be useful to try the codeapath of the Permission logic and user prompt. Additionally, they could be useful for the browser that implement the Custom Handlers API but not the WebDriver command (eg Firefox). Is this enough to keep all the manual tests ? I'm not sure; I trust your judgement on this regard. |
|
I guess that's fair. I worry a bit that they might not get maintained over time. I guess that would be easy enough to spot with git and we can make a call at that time what to do. And a lot of logic is shared which should reduce that issue as well. |
javifernandez
force-pushed
the
test-automation-for-custom-handlers
branch
2 times, most recently
from
3cdea71
to
07c4e76
Compare
javifernandez
force-pushed
the
test-automation-for-custom-handlers
branch
2 times, most recently
from
161f22e
to
e57b2f4
Compare
This new WebDriver extension command allows to registerProtocolHandler method of the HTML API to operate under an automatic mode. This PR defines also new automated tests for the registerProtocolHandler based on the manual tests that we alaready have.
javifernandez
force-pushed
the
test-automation-for-custom-handlers
branch
from
e57b2f4
to
4cee442
Compare
|
@annevk could you take another look at this PR ? Perhaps we can discuss again about what to do with the manual tests; I think they still have some value, since they test a different codepath and definitively the only option for browsers that don't implement the new WebDriver extension command (eg, Firefox). |
|
@domenic perhaps you could rubber-stamp the PR, given that these tests are designed for the registerProtocolHandler method of the HTML spec. |
|
@jgraham your input would be interesting as well, given that Gecko is the other engine that implements the registerProtocolHandler method. |
|
I'm sorry, I don't have time to review this PR. I see you already have an approval. |
javifernandez
removed request for
jdm,
jgraham,
foolip,
domenic,
zqzhang and
DanielRyanSmith
This commit implements the actions and protocol to use a new webdriver extension command to allow testing automation of the registerProtocolHandler method.
Additionally, this change also adds new tests which are automated versions of the manual tests already defined for the registerProtocolHandler method.