Test that various MessageEvents are trusted #4025

domenic · 2016-10-19T19:42:34Z

See whatwg/html#1935.

wpt-pr-bot · 2016-10-19T19:42:42Z

Reviewers for this pull request are: @Ms2ger, @velmont, @Yaffle, @aogilvie, @deniak, @jdm, @plehegar, @sideshowbarker, and @zqzhang.

domenic · 2016-10-19T19:44:20Z

Note that I cannot get the BroadcastChannel tests to work in Chrome or Firefox---they timeout instead---so if someone can figure out my mistake that would be great.

annevk · 2016-10-20T08:01:08Z

You need to have at least two BroadcastChannel objects I think. Ideally in separate globals. (Maybe use an <iframe>?)

sideshowbarker · 2016-10-20T12:56:59Z

I cannot get the BroadcastChannel tests to work in Chrome or Firefox---they timeout instead

You need to have at least two BroadcastChannel objects I think. Ideally in separate globals.

The following works (though not sure it’s the best way to do it…)

diff --git a/webmessaging/MessageEvent-trusted.html b/webmessaging/MessageEvent-trusted.html
index e3d26f8..502cd51 100644
--- a/webmessaging/MessageEvent-trusted.html
+++ b/webmessaging/MessageEvent-trusted.html
@@ -1,3 +1,8 @@
+<!--
+const channel = new BroadcastChannel("name");
+channel.postMessage("ping");
+/*
+-->
 <!DOCTYPE html>
 <title>MessagePort message events are trusted</title>
 <script src="/resources/testharness.js"></script>
@@ -26,13 +31,13 @@ async_test(t => {
 async_test(t => {
   assert_true("BroadcastChannel" in self, "The browser must support BroadcastChannel");

+  const worker = new Worker("#");
   const channel = new BroadcastChannel("name");

   channel.onmessage = t.step_func_done(e => {
     assert_equals(e.isTrusted, true);
   });

-  channel.postMessage("ping");
 }, "With a BroadcastChannel");

 async_test(t => {
@@ -43,3 +48,6 @@ async_test(t => {
   window.postMessage("ping", "*");
 }, "With window");
 </script>
+<!--
+*/
+-->

(btw would be nice if we could just use template literals in WPT tests but I’m told we shouldn’t yet)

domenic · 2016-10-20T18:21:07Z

Thanks all, fixed the test, and now it indeed passes in Chrome and Firefox.

wpt-stability-bot · 2016-10-20T18:24:19Z

Testing in Chrome
Files changed:

/home/travis/build/w3c/web-platform-tests/eventsource/eventsource-onmessage-trusted.htm
/home/travis/build/w3c/web-platform-tests/webmessaging/MessageEvent-trusted-worker.js
/home/travis/build/w3c/web-platform-tests/webmessaging/MessageEvent-trusted.html

All results were stable

All results

Test	Subtest	Results
/eventsource/eventsource-onmessage-trusted.htm		OK: 10
	EventSource message events are trusted	PASS: 10
/webmessaging/MessageEvent-trusted.html		OK: 10
	With a MessageChannel and its MessagePorts	PASS: 10
	With a BroadcastChannel	PASS: 10
	With window	PASS: 10

wpt-stability-bot · 2016-10-20T18:24:55Z

Testing in Firefox
Files changed:

/home/travis/build/w3c/web-platform-tests/eventsource/eventsource-onmessage-trusted.htm
/home/travis/build/w3c/web-platform-tests/webmessaging/MessageEvent-trusted-worker.js
/home/travis/build/w3c/web-platform-tests/webmessaging/MessageEvent-trusted.html

All results were stable

All results

Test	Subtest	Results
/eventsource/eventsource-onmessage-trusted.htm		OK: 10
	EventSource message events are trusted	PASS: 10
/webmessaging/MessageEvent-trusted.html		OK: 10
	With a MessageChannel and its MessagePorts	PASS: 10
	With a BroadcastChannel	PASS: 10
	With window	FAIL: 10

cdumez · 2016-10-20T19:06:22Z

Wow, it now runs tests in browsers!? so cool!
I wish it would cover Safari (TP) too :D

wpt-stability-bot · 2016-10-26T19:21:03Z

Firefox

Testing revision ab50501
Starting 10 test iterations
All results were stable

All results

/eventsource/eventsource-onmessage-trusted.htm

Subtest	Results
	OK
EventSource message events are trusted	PASS

/webmessaging/MessageEvent-trusted.html

Subtest	Results
	OK
With a MessageChannel and its MessagePorts	PASS
With a BroadcastChannel	PASS
With window	FAIL

wpt-stability-bot · 2016-10-26T19:21:29Z

Chrome

Testing revision 4fd89ca
Starting 10 test iterations
All results were stable

All results

/eventsource/eventsource-onmessage-trusted.htm

Subtest	Results
	OK
EventSource message events are trusted	PASS

/webmessaging/MessageEvent-trusted.html

Subtest	Results
	OK
With a MessageChannel and its MessagePorts	PASS
With a BroadcastChannel	PASS
With window	PASS

mkruisselbrink · 2016-11-30T00:50:51Z

webmessaging/MessageEvent-trusted.html

+async_test(t => {
+  assert_true("BroadcastChannel" in self, "The browser must support BroadcastChannel");
+
+  new Worker("MessageEvent-trusted-worker.js");


It is probably safer to not create this worker until after you've created the BroadcastChannel instance and added the onmessage event handler. I don't think there is anything that guarantees the worker won't be created, ran, and posts its message to the channel before this method has a chance to connect to the channel itself (unless I'm missing something in how cross-thread-synchronization is specified in the html spec)

See whatwg/html#1935.

domenic · 2016-12-05T22:40:22Z

@mkruisselbrink fixed, thanks!

wpt-stability-bot · 2016-12-05T22:46:32Z

Firefox

Testing revision 814f27d
Starting 10 test iterations
All results were stable

All results

/eventsource/eventsource-onmessage-trusted.htm

Subtest	Results
	OK
`EventSource message events are trusted`	PASS

/webmessaging/MessageEvent-trusted.html

Subtest	Results
	OK
`With a MessageChannel and its MessagePorts`	PASS
`With a BroadcastChannel`	PASS
`With window`	FAIL

wpt-stability-bot · 2016-12-05T22:47:57Z

Chrome

Testing revision 814f27d
Starting 10 test iterations
All results were stable

All results

/eventsource/eventsource-onmessage-trusted.htm

Subtest	Results
	OK
`EventSource message events are trusted`	PASS

/webmessaging/MessageEvent-trusted.html

Subtest	Results
	OK
`With a MessageChannel and its MessagePorts`	PASS
`With a BroadcastChannel`	PASS
`With window`	PASS

domenic · 2017-02-08T20:42:55Z

Ping @mkruisselbrink for a final sign-off? This seems to have gotten left behind at some point.

mkruisselbrink · 2017-02-08T20:46:10Z

Ping @mkruisselbrink for a final sign-off? This seems to have gotten left behind at some point.

Looks good to me.

wpt-pr-bot added eventsource webmessaging wg-webapps labels Oct 19, 2016

domenic mentioned this pull request Oct 19, 2016

Set some MessageEvent's isTrusted attributes to true whatwg/html#1935

Merged

ayg closed this Oct 26, 2016

ayg deleted the messageevents-trusted branch October 26, 2016 17:38

ayg restored the messageevents-trusted branch October 26, 2016 18:04

ayg reopened this Oct 26, 2016

domenic mentioned this pull request Oct 28, 2016

Specify the realm for the SSE MessageEvent whatwg/html#1988

Merged

mkruisselbrink reviewed Nov 30, 2016

View reviewed changes

domenic added 3 commits December 5, 2016 14:39

Test that various MessageEvents are trusted

547b4cc

See whatwg/html#1935.

Fix broadcastchannel test

7cf95cd

Move worker per mkrusselbrink's review

4eb4b2e

domenic force-pushed the messageevents-trusted branch from 00fcdc8 to 4eb4b2e Compare December 5, 2016 22:40

domenic merged commit 0541620 into master Feb 8, 2017

domenic deleted the messageevents-trusted branch February 8, 2017 20:46

snyk-bot mentioned this pull request Aug 17, 2021

[Snyk] Fix for 6 vulnerabilities MaxMood96/web-platform-tests#1

Open

snyk-bot mentioned this pull request Mar 23, 2022

[Snyk] Security upgrade mocha from 3.2.0 to 6.2.3 MaxMood96/web-platform-tests#11

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Test that various MessageEvents are trusted #4025

Test that various MessageEvents are trusted #4025

domenic commented Oct 19, 2016

wpt-pr-bot commented Oct 19, 2016

domenic commented Oct 19, 2016

annevk commented Oct 20, 2016

sideshowbarker commented Oct 20, 2016

domenic commented Oct 20, 2016

wpt-stability-bot commented Oct 20, 2016

wpt-stability-bot commented Oct 20, 2016

cdumez commented Oct 20, 2016

wpt-stability-bot commented Oct 26, 2016

wpt-stability-bot commented Oct 26, 2016

mkruisselbrink Nov 30, 2016

domenic commented Dec 5, 2016

wpt-stability-bot commented Dec 5, 2016

wpt-stability-bot commented Dec 5, 2016

domenic commented Feb 8, 2017

mkruisselbrink commented Feb 8, 2017

Test that various MessageEvents are trusted #4025

Test that various MessageEvents are trusted #4025

Conversation

domenic commented Oct 19, 2016

wpt-pr-bot commented Oct 19, 2016

domenic commented Oct 19, 2016

annevk commented Oct 20, 2016

sideshowbarker commented Oct 20, 2016

domenic commented Oct 20, 2016

wpt-stability-bot commented Oct 20, 2016

All results

wpt-stability-bot commented Oct 20, 2016

All results

cdumez commented Oct 20, 2016

wpt-stability-bot commented Oct 26, 2016

Firefox

All results

/eventsource/eventsource-onmessage-trusted.htm

/webmessaging/MessageEvent-trusted.html

wpt-stability-bot commented Oct 26, 2016

Chrome

All results

/eventsource/eventsource-onmessage-trusted.htm

/webmessaging/MessageEvent-trusted.html

mkruisselbrink Nov 30, 2016

Choose a reason for hiding this comment

domenic commented Dec 5, 2016

wpt-stability-bot commented Dec 5, 2016

Firefox

All results

/eventsource/eventsource-onmessage-trusted.htm

/webmessaging/MessageEvent-trusted.html

wpt-stability-bot commented Dec 5, 2016

Chrome

All results

/eventsource/eventsource-onmessage-trusted.htm

/webmessaging/MessageEvent-trusted.html

domenic commented Feb 8, 2017

mkruisselbrink commented Feb 8, 2017