Specify the realm for the SSE MessageEvent #1988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #1959. All other MessageEvents are created as part of "fire an event", which is covered by whatwg/dom#352.
|
This changes |
|
Good call, I mashed up web-platform-tests/wpt#4025 and web-platform-tests/wpt#4067 in my mind, but it turns out I haven't written a test for this exact scenario. Let me do that. |
domenic
added
the
needs tests
domenic
added a commit
to web-platform-tests/wpt
that referenced
this pull request
Oct 31, 2016
Matches the spec clarification at whatwg/html#1988.
|
Tests added at web-platform-tests/wpt#4134 |
domenic
removed
the
needs tests
zcorpan
approved these changes
Nov 1, 2016
zcorpan
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Nov 1, 2016
Matches the spec clarification at whatwg/html#1988.
tomoyukilabs
pushed a commit
to tomoyukilabs/web-platform-tests
that referenced
this pull request
Nov 7, 2016
Matches the spec clarification at whatwg/html#1988.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1959. All other MessageEvents are created as part of "fire an
event", which is covered by whatwg/dom#352.
Tests are part of web-platform-tests/wpt#4067.