Fenced frames: Navigate to about:blank when config attr is set to null. #40793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Jun 28, 2023
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-4636931
branch
7 times, most recently
from
2277691
to
d522ab3
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-4636931
branch
from
d522ab3
to
7ab1e68
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-4636931
branch
2 times, most recently
from
0f0a4b9
to
fd90808
Compare
Note: This does not affect the initial state of the config member, and only takes affect when it is explicitly set to null. Continuation of https://crrev.com/c/4341914. click `Add FencedFrame`, and enter `document.querySelector('fencedframe').config = null` in the console; the frame should display a blank page. Change-Id: I07dbcefaea25bea74f4a3ad6880800036224338a Test: 1. Added a browser test 2. Navigate to https://mparch.glitch.me, Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4636931 Commit-Queue: Andrew Verge <averge@chromium.org> Reviewed-by: Dominic Farolino <dom@chromium.org> Cr-Commit-Position: refs/heads/main@{#1168356}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-4636931
branch
from
fd90808
to
63ca24c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: This does not affect the initial state of the config member, and
only takes affect when it is explicitly set to null. Continuation of
https://crrev.com/c/4341914.
click
Add FencedFrame, and enterdocument.querySelector('fencedframe').config = nullin the console;the frame should display a blank page.
Change-Id: I07dbcefaea25bea74f4a3ad6880800036224338a
Test: 1. Added a browser test 2. Navigate to https://mparch.glitch.me,
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4636931
Commit-Queue: Andrew Verge <averge@chromium.org>
Reviewed-by: Dominic Farolino <dom@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1168356}