Store the COOP restrict crossOriginIsolated bit in policy container. #40890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Jul 5, 2023
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-4666003
branch
10 times, most recently
from
84545a6
to
158f2c8
Compare
chromium-wpt-export-bot
changed the title
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-4666003
branch
7 times, most recently
from
016ac2f
to
3d6e16e
Compare
In https://crrev.com/c/4479858, we introduced a new boolean that constrains whether an execution context can be considered crossOriginIsolated. It is computed by the browser, depending on whether the COOP origin matches the actual origin. This boolean is computed and sent to the renderer at window creation time, or at commit time for subframes. It causes breakage such as b/288962508 (Google only) because SharedArrayBuffer's constructor sometimes needs to be enabled earlier than CommitNavigation, which causes SharedArrayBuffer to be undefined even though crossOriginIsolated is true. This CL instead puts the boolean inside the policy container and lets it handles inheritance. Bug: 1385827 Change-Id: I1330c30ad056d9f94ee7b7747eac68ae47b56acc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4666003 Commit-Queue: Jonathan Hao <phao@chromium.org> Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by: Arthur Hemery <ahemery@chromium.org> Reviewed-by: Yoav Weiss <yoavweiss@chromium.org> Cr-Commit-Position: refs/heads/main@{#1168653}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-4666003
branch
from
3d6e16e
to
54847c3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In https://crrev.com/c/4479858, we introduced a new boolean that
constrains whether an execution context can be considered
crossOriginIsolated. It is computed by the browser, depending on whether
the COOP origin matches the actual origin. This boolean is computed and
sent to the renderer at window creation time, or at commit time for
subframes. It causes breakage such as b/288962508 (Google
only) because SharedArrayBuffer's constructor sometimes needs to be
enabled earlier than CommitNavigation, which causes SharedArrayBuffer to
be undefined even though crossOriginIsolated is true.
This CL instead puts the boolean inside the policy container and lets it
handles inheritance.
Bug: 1385827
Change-Id: I1330c30ad056d9f94ee7b7747eac68ae47b56acc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4666003
Commit-Queue: Jonathan Hao <phao@chromium.org>
Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Reviewed-by: Arthur Hemery <ahemery@chromium.org>
Reviewed-by: Yoav Weiss <yoavweiss@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1168653}