Add tests for base url in detached docs, javascript: url nav. #40969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Jul 11, 2023
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-4678280
branch
2 times, most recently
from
ad24306
to
5605a6e
Compare
Web tests to verify that (i) a detached about:blank or about:srcdoc document retains the base url it was created with, and (ii) navigating about:blank to a javascript: url also retains the base url. Bug: 1356658 Change-Id: Ic40e658981e9ec5b3c66a3d39a0ad10ce8f6691e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4678280 Commit-Queue: James Maclean <wjmaclean@chromium.org> Reviewed-by: Dominic Farolino <dom@chromium.org> Cr-Commit-Position: refs/heads/main@{#1169370}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-4678280
branch
from
5605a6e
to
c8428f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Web tests to verify that (i) a detached about:blank or about:srcdoc
document retains the base url it was created with, and (ii) navigating
about:blank to a javascript: url also retains the base url.
Bug: 1356658
Change-Id: Ic40e658981e9ec5b3c66a3d39a0ad10ce8f6691e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4678280
Commit-Queue: James Maclean <wjmaclean@chromium.org>
Reviewed-by: Dominic Farolino <dom@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1169370}