Shared Storage: Change from per-origin to per-site budgets #42224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Sep 28, 2023
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-4879582
branch
4 times, most recently
from
16c3f12
to
8770de5
Compare
We update to using per-site privacy budgets instead of per-origin privacy budgets. This will align with enrollment enforcement, which is per-site. See also WICG/shared-storage#112 and WICG/shared-storage#118. To accomplish this, we migrate the `SharedStorageDatabase` to version 4, where the `budget_mapping` table's `context_origin` column has been renamed to `context_site`, and any existing data for version 3 databases will have each serialized origin in that column replaced by the corresponding serialization of the origin's site. We also update the names and types of other members and parameters as needed. Bug: 1218540,1485598 Change-Id: I3d956f5f2cd54a5da76a20e7d63411b3b7fc51ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4879582 Reviewed-by: Philip Rogers <pdr@chromium.org> Commit-Queue: Cammie Smith Barnes <cammie@chromium.org> Reviewed-by: Ayu Ishii <ayui@chromium.org> Reviewed-by: Garrett Tanzer <gtanzer@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Reviewed-by: danakj <danakj@chromium.org> Reviewed-by: Yao Xiao <yaoxia@chromium.org> Cr-Commit-Position: refs/heads/main@{#1204170}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-4879582
branch
from
8770de5
to
a8872e6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We update to using per-site privacy budgets instead of per-origin
privacy budgets. This will align with enrollment enforcement, which is
per-site.
See also WICG/shared-storage#112 and
WICG/shared-storage#118.
To accomplish this, we migrate the
SharedStorageDatabaseto version4, where the
budget_mappingtable'scontext_origincolumn has beenrenamed to
context_site, and any existing data for version 3databases will have each serialized origin in that column replaced by
the corresponding serialization of the origin's site.
We also update the names and types of other members and parameters as
needed.
Bug: 1218540,1485598
Change-Id: I3d956f5f2cd54a5da76a20e7d63411b3b7fc51ef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4879582
Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Cammie Smith Barnes <cammie@chromium.org>
Reviewed-by: Ayu Ishii <ayui@chromium.org>
Reviewed-by: Garrett Tanzer <gtanzer@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Reviewed-by: Yao Xiao <yaoxia@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1204170}