Add allow-discrete to non-interpolable WPTs #42857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Oct 31, 2023
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-4989757
branch
from
1260c33
to
f864a48
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-4989757
branch
2 times, most recently
from
61b6540
to
386d592
Compare
chromium-wpt-export-bot
changed the title
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-4989757
branch
from
386d592
to
7bef3ea
Compare
3 tasks
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-4989757
branch
from
7bef3ea
to
e47e328
Compare
This patch changes the test runner for animation tests in WPT to additionally test transition-behavior:allow-discrete for any property that we are running a non-interpolable or non-animatable test on. Change-Id: I7e13600c0182ab5e4839fea4e32e759673abe84e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4989757 Reviewed-by: David Baron <dbaron@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/main@{#1222343}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-4989757
branch
from
e47e328
to
f482a94
Compare
|
@josepharhar I think this push unintentionally moved-the-goalposts for a handful of interop-2023 tests, e.g. the various Firefox and Safari are now shown as not-passing chunks of those tests, specifically subtests I don't think you intended to adjust things such that engines must implement |
|
Yeah makes sense, I'll revert it |
chromium-wpt-export-bot
pushed a commit
that referenced
this pull request
Nov 16, 2023
This reverts commit d43c0e4219504e68479d2c9e519ba0825cc11b28. Reason for revert: Affects results for interop2023 in an unfair way because transition-behavior is not part of interop2023: #42857 (comment) Original change's description: > Add allow-discrete to non-interpolable WPTs > > This patch changes the test runner for animation tests in WPT to > additionally test transition-behavior:allow-discrete for any property > that we are running a non-interpolable or non-animatable test on. > > Change-Id: I7e13600c0182ab5e4839fea4e32e759673abe84e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4989757 > Reviewed-by: David Baron <dbaron@chromium.org> > Commit-Queue: Joey Arhar <jarhar@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1222343} Change-Id: I1d067b0c79b1d16b8fdbd1e672f3db9d1befca74
chromium-wpt-export-bot
pushed a commit
that referenced
this pull request
Nov 16, 2023
This reverts commit d43c0e4219504e68479d2c9e519ba0825cc11b28. Reason for revert: Affects results for interop2023 in an unfair way because transition-behavior is not part of interop2023: #42857 (comment) Original change's description: > Add allow-discrete to non-interpolable WPTs > > This patch changes the test runner for animation tests in WPT to > additionally test transition-behavior:allow-discrete for any property > that we are running a non-interpolable or non-animatable test on. > > Change-Id: I7e13600c0182ab5e4839fea4e32e759673abe84e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4989757 > Reviewed-by: David Baron <dbaron@chromium.org> > Commit-Queue: Joey Arhar <jarhar@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1222343} Change-Id: I1d067b0c79b1d16b8fdbd1e672f3db9d1befca74
chromium-wpt-export-bot
pushed a commit
that referenced
this pull request
Nov 16, 2023
This reverts commit d43c0e4219504e68479d2c9e519ba0825cc11b28. Reason for revert: Affects results for interop2023 in an unfair way because transition-behavior is not part of interop2023: #42857 (comment) Original change's description: > Add allow-discrete to non-interpolable WPTs > > This patch changes the test runner for animation tests in WPT to > additionally test transition-behavior:allow-discrete for any property > that we are running a non-interpolable or non-animatable test on. > > Change-Id: I7e13600c0182ab5e4839fea4e32e759673abe84e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4989757 > Reviewed-by: David Baron <dbaron@chromium.org> > Commit-Queue: Joey Arhar <jarhar@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1222343} Change-Id: I1d067b0c79b1d16b8fdbd1e672f3db9d1befca74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5038074 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: David Baron <dbaron@chromium.org> Reviewed-by: David Baron <dbaron@chromium.org> Cr-Commit-Position: refs/heads/main@{#1225735}
chromium-wpt-export-bot
pushed a commit
that referenced
this pull request
Nov 16, 2023
This reverts commit d43c0e4219504e68479d2c9e519ba0825cc11b28. Reason for revert: Affects results for interop2023 in an unfair way because transition-behavior is not part of interop2023: #42857 (comment) Original change's description: > Add allow-discrete to non-interpolable WPTs > > This patch changes the test runner for animation tests in WPT to > additionally test transition-behavior:allow-discrete for any property > that we are running a non-interpolable or non-animatable test on. > > Change-Id: I7e13600c0182ab5e4839fea4e32e759673abe84e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4989757 > Reviewed-by: David Baron <dbaron@chromium.org> > Commit-Queue: Joey Arhar <jarhar@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1222343} Change-Id: I1d067b0c79b1d16b8fdbd1e672f3db9d1befca74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5038074 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: David Baron <dbaron@chromium.org> Reviewed-by: David Baron <dbaron@chromium.org> Cr-Commit-Position: refs/heads/main@{#1225735}
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Nov 22, 2023
…olable WPTs", a=testonly Automatic update from web-platform-tests Revert "Add allow-discrete to non-interpolable WPTs" This reverts commit d43c0e4219504e68479d2c9e519ba0825cc11b28. Reason for revert: Affects results for interop2023 in an unfair way because transition-behavior is not part of interop2023: web-platform-tests/wpt#42857 (comment) Original change's description: > Add allow-discrete to non-interpolable WPTs > > This patch changes the test runner for animation tests in WPT to > additionally test transition-behavior:allow-discrete for any property > that we are running a non-interpolable or non-animatable test on. > > Change-Id: I7e13600c0182ab5e4839fea4e32e759673abe84e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4989757 > Reviewed-by: David Baron <dbaron@chromium.org> > Commit-Queue: Joey Arhar <jarhar@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1222343} Change-Id: I1d067b0c79b1d16b8fdbd1e672f3db9d1befca74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5038074 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: David Baron <dbaron@chromium.org> Reviewed-by: David Baron <dbaron@chromium.org> Cr-Commit-Position: refs/heads/main@{#1225735} -- wpt-commits: 62477674bacb9057376d53c190ec89f0d80ec5cf wpt-pr: 43212
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Nov 22, 2023
…olable WPTs", a=testonly Automatic update from web-platform-tests Revert "Add allow-discrete to non-interpolable WPTs" This reverts commit d43c0e4219504e68479d2c9e519ba0825cc11b28. Reason for revert: Affects results for interop2023 in an unfair way because transition-behavior is not part of interop2023: web-platform-tests/wpt#42857 (comment) Original change's description: > Add allow-discrete to non-interpolable WPTs > > This patch changes the test runner for animation tests in WPT to > additionally test transition-behavior:allow-discrete for any property > that we are running a non-interpolable or non-animatable test on. > > Change-Id: I7e13600c0182ab5e4839fea4e32e759673abe84e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4989757 > Reviewed-by: David Baron <dbaron@chromium.org> > Commit-Queue: Joey Arhar <jarhar@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1222343} Change-Id: I1d067b0c79b1d16b8fdbd1e672f3db9d1befca74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5038074 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: David Baron <dbaron@chromium.org> Reviewed-by: David Baron <dbaron@chromium.org> Cr-Commit-Position: refs/heads/main@{#1225735} -- wpt-commits: 62477674bacb9057376d53c190ec89f0d80ec5cf wpt-pr: 43212
vinnydiehl
pushed a commit
to vinnydiehl/mozilla-unified
that referenced
this pull request
Nov 24, 2023
…olable WPTs", a=testonly Automatic update from web-platform-tests Revert "Add allow-discrete to non-interpolable WPTs" This reverts commit d43c0e4219504e68479d2c9e519ba0825cc11b28. Reason for revert: Affects results for interop2023 in an unfair way because transition-behavior is not part of interop2023: web-platform-tests/wpt#42857 (comment) Original change's description: > Add allow-discrete to non-interpolable WPTs > > This patch changes the test runner for animation tests in WPT to > additionally test transition-behavior:allow-discrete for any property > that we are running a non-interpolable or non-animatable test on. > > Change-Id: I7e13600c0182ab5e4839fea4e32e759673abe84e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4989757 > Reviewed-by: David Baron <dbaron@chromium.org> > Commit-Queue: Joey Arhar <jarhar@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1222343} Change-Id: I1d067b0c79b1d16b8fdbd1e672f3db9d1befca74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5038074 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: David Baron <dbaron@chromium.org> Reviewed-by: David Baron <dbaron@chromium.org> Cr-Commit-Position: refs/heads/main@{#1225735} -- wpt-commits: 62477674bacb9057376d53c190ec89f0d80ec5cf wpt-pr: 43212
vinnydiehl
pushed a commit
to vinnydiehl/mozilla-unified
that referenced
this pull request
Nov 24, 2023
…olable WPTs", a=testonly Automatic update from web-platform-tests Revert "Add allow-discrete to non-interpolable WPTs" This reverts commit d43c0e4219504e68479d2c9e519ba0825cc11b28. Reason for revert: Affects results for interop2023 in an unfair way because transition-behavior is not part of interop2023: web-platform-tests/wpt#42857 (comment) Original change's description: > Add allow-discrete to non-interpolable WPTs > > This patch changes the test runner for animation tests in WPT to > additionally test transition-behavior:allow-discrete for any property > that we are running a non-interpolable or non-animatable test on. > > Change-Id: I7e13600c0182ab5e4839fea4e32e759673abe84e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4989757 > Reviewed-by: David Baron <dbaron@chromium.org> > Commit-Queue: Joey Arhar <jarhar@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1222343} Change-Id: I1d067b0c79b1d16b8fdbd1e672f3db9d1befca74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5038074 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: David Baron <dbaron@chromium.org> Reviewed-by: David Baron <dbaron@chromium.org> Cr-Commit-Position: refs/heads/main@{#1225735} -- wpt-commits: 62477674bacb9057376d53c190ec89f0d80ec5cf wpt-pr: 43212
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Nov 30, 2023
…olable WPTs", a=testonly Automatic update from web-platform-tests Revert "Add allow-discrete to non-interpolable WPTs" This reverts commit d43c0e4219504e68479d2c9e519ba0825cc11b28. Reason for revert: Affects results for interop2023 in an unfair way because transition-behavior is not part of interop2023: web-platform-tests/wpt#42857 (comment) Original change's description: > Add allow-discrete to non-interpolable WPTs > > This patch changes the test runner for animation tests in WPT to > additionally test transition-behavior:allow-discrete for any property > that we are running a non-interpolable or non-animatable test on. > > Change-Id: I7e13600c0182ab5e4839fea4e32e759673abe84e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4989757 > Reviewed-by: David Baron <dbaronchromium.org> > Commit-Queue: Joey Arhar <jarharchromium.org> > Cr-Commit-Position: refs/heads/main{#1222343} Change-Id: I1d067b0c79b1d16b8fdbd1e672f3db9d1befca74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5038074 Bot-Commit: Rubber Stamper <rubber-stamperappspot.gserviceaccount.com> Commit-Queue: David Baron <dbaronchromium.org> Reviewed-by: David Baron <dbaronchromium.org> Cr-Commit-Position: refs/heads/main{#1225735} -- wpt-commits: 62477674bacb9057376d53c190ec89f0d80ec5cf wpt-pr: 43212 UltraBlame original commit: e6eedff2a45453ff5d5bd72a1ce60e802420ccb6
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Nov 30, 2023
…olable WPTs", a=testonly Automatic update from web-platform-tests Revert "Add allow-discrete to non-interpolable WPTs" This reverts commit d43c0e4219504e68479d2c9e519ba0825cc11b28. Reason for revert: Affects results for interop2023 in an unfair way because transition-behavior is not part of interop2023: web-platform-tests/wpt#42857 (comment) Original change's description: > Add allow-discrete to non-interpolable WPTs > > This patch changes the test runner for animation tests in WPT to > additionally test transition-behavior:allow-discrete for any property > that we are running a non-interpolable or non-animatable test on. > > Change-Id: I7e13600c0182ab5e4839fea4e32e759673abe84e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4989757 > Reviewed-by: David Baron <dbaronchromium.org> > Commit-Queue: Joey Arhar <jarharchromium.org> > Cr-Commit-Position: refs/heads/main{#1222343} Change-Id: I1d067b0c79b1d16b8fdbd1e672f3db9d1befca74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5038074 Bot-Commit: Rubber Stamper <rubber-stamperappspot.gserviceaccount.com> Commit-Queue: David Baron <dbaronchromium.org> Reviewed-by: David Baron <dbaronchromium.org> Cr-Commit-Position: refs/heads/main{#1225735} -- wpt-commits: 62477674bacb9057376d53c190ec89f0d80ec5cf wpt-pr: 43212 UltraBlame original commit: e6eedff2a45453ff5d5bd72a1ce60e802420ccb6
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Nov 30, 2023
…olable WPTs", a=testonly Automatic update from web-platform-tests Revert "Add allow-discrete to non-interpolable WPTs" This reverts commit d43c0e4219504e68479d2c9e519ba0825cc11b28. Reason for revert: Affects results for interop2023 in an unfair way because transition-behavior is not part of interop2023: web-platform-tests/wpt#42857 (comment) Original change's description: > Add allow-discrete to non-interpolable WPTs > > This patch changes the test runner for animation tests in WPT to > additionally test transition-behavior:allow-discrete for any property > that we are running a non-interpolable or non-animatable test on. > > Change-Id: I7e13600c0182ab5e4839fea4e32e759673abe84e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4989757 > Reviewed-by: David Baron <dbaronchromium.org> > Commit-Queue: Joey Arhar <jarharchromium.org> > Cr-Commit-Position: refs/heads/main{#1222343} Change-Id: I1d067b0c79b1d16b8fdbd1e672f3db9d1befca74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5038074 Bot-Commit: Rubber Stamper <rubber-stamperappspot.gserviceaccount.com> Commit-Queue: David Baron <dbaronchromium.org> Reviewed-by: David Baron <dbaronchromium.org> Cr-Commit-Position: refs/heads/main{#1225735} -- wpt-commits: 62477674bacb9057376d53c190ec89f0d80ec5cf wpt-pr: 43212 UltraBlame original commit: e6eedff2a45453ff5d5bd72a1ce60e802420ccb6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch changes the test runner for animation tests in WPT to
additionally test transition-behavior:allow-discrete for any property
that we are running a non-interpolable or non-animatable test on.
Change-Id: I7e13600c0182ab5e4839fea4e32e759673abe84e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4989757
Reviewed-by: David Baron <dbaron@chromium.org>
Commit-Queue: Joey Arhar <jarhar@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1222343}